From: Anoop C S <anoopcs@cryptolab.net>
Date: Fri, 29 Nov 2024 18:52:30 +0000 (+0530)
Subject: mds: Fix invalid access of mdr->dn[0].back()
X-Git-Tag: v20.0.0~384^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=d2386e80bb25bd70c864c0954ce84718019ab955;p=ceph.git

mds: Fix invalid access of mdr->dn[0].back()

See https://github.com/ceph/ceph/pull/31534 for a similar fix.

Fixes: https://tracker.ceph.com/issues/69059

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
---

diff --git a/src/mds/Server.cc b/src/mds/Server.cc
index 5874a3dce56..e66b5aa08c7 100644
--- a/src/mds/Server.cc
+++ b/src/mds/Server.cc
@@ -4167,7 +4167,7 @@ void Server::handle_client_getattr(const MDRequestRef& mdr, bool is_lookup)
 
     if (r < 0) {
       // fall-thru. let rdlock_path_pin_ref() check again.
-    } else if (is_lookup) {
+    } else if (is_lookup && mdr->dn[0].size()) {
       CDentry* dn = mdr->dn[0].back();
       mdr->pin(dn);
       auto em = dn->batch_ops.emplace(std::piecewise_construct, std::forward_as_tuple(mask), std::forward_as_tuple());
@@ -4274,7 +4274,7 @@ void Server::handle_client_getattr(const MDRequestRef& mdr, bool is_lookup)
   // reply
   dout(10) << "reply to stat on " << *req << dendl;
   mdr->tracei = ref;
-  if (is_lookup)
+  if (is_lookup && mdr->dn[0].size())
     mdr->tracedn = mdr->dn[0].back();
   respond_to_request(mdr, 0);
 }