From: Danny Al-Gaaf Date: Fri, 10 May 2013 13:19:55 +0000 (+0200) Subject: mds/MDCache.cc: add NULL pointer check X-Git-Tag: v0.63~41^2~9 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=d258df4da31cb7411198f8e52ee76ec161ebb92d;p=ceph.git mds/MDCache.cc: add NULL pointer check Check for result of get_inode() for NULL before use the pointer. 716990 Dereference null return value (CWE-476) Signed-off-by: Danny Al-Gaaf --- diff --git a/src/mds/MDCache.cc b/src/mds/MDCache.cc index e69d37ee256f..55ddf874776a 100644 --- a/src/mds/MDCache.cc +++ b/src/mds/MDCache.cc @@ -9195,7 +9195,7 @@ void MDCache::handle_discover(MDiscover *dis) cur = get_inode(dis->get_base_ino(), snapid); if (!cur && snapid != CEPH_NOSNAP) { cur = get_inode(dis->get_base_ino()); - if (!cur->is_multiversion()) + if (cur && !cur->is_multiversion()) cur = NULL; // nope! }