From: myoungwon oh <ohmyoungwon@gmail.com>
Date: Fri, 6 Nov 2020 10:36:39 +0000 (+0900)
Subject: osd: add comment to explain why EC pool is disallowed
X-Git-Tag: v16.1.0~374^2~15
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=d4abec3b4480984b95cadd43a3452453198694f4;p=ceph.git

osd: add comment to explain why EC pool is disallowed

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsumg.com>
---

diff --git a/src/osd/PrimaryLogPG.cc b/src/osd/PrimaryLogPG.cc
index 47db8c5603d..af6a5a8dfe7 100644
--- a/src/osd/PrimaryLogPG.cc
+++ b/src/osd/PrimaryLogPG.cc
@@ -10125,7 +10125,12 @@ int PrimaryLogPG::do_cdc(const object_info_t& oi, bufferlist& bl, vector<pair<ui
   }
   while (cur_off < oi.size && cur_off < max_window_size) {
     bufferlist chunk_data;
-    // TODO: Do we need to support EC?
+    /**
+     * We disable EC pool as a base tier of distributed dedup.
+     * The reason why we disallow erasure code pool here is that the EC pool does not support objects_read_sync(). 
+     * Therefore, we should change the current implementation totally to make EC pool compatible. 
+     * As s result, we leave this as a future work.
+     */
     int r = pgbackend->objects_read_sync(
 	oi.soid, cur_off, max_window_size, 0, &chunk_data);
     if (r < 0) {