From: Nathan Cutler <ncutler@suse.com>
Date: Wed, 12 Jul 2017 03:05:43 +0000 (+0200)
Subject: tools: ceph-release-notes: handle an edge case
X-Git-Tag: v12.1.1~54^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=d4d8f3cd62a2138518bade233293a9ee6ea68750;p=ceph.git

tools: ceph-release-notes: handle an edge case

If the merge commit message consists of a single "Reviewed-by:" line, the
script fails at the line because len(lines) is zero.

    duplicates_pr_title = lines[0] == pr['title'].strip()

Signed-off-by: Nathan Cutler <ncutler@suse.com>
---

diff --git a/src/script/ceph-release-notes b/src/script/ceph-release-notes
index 6f0d70cf7f7f..0008897413b8 100755
--- a/src/script/ceph-release-notes
+++ b/src/script/ceph-release-notes
@@ -129,6 +129,7 @@ def make_release_notes(gh, repo, ref, plaintext, verbose, strict, use_tags):
                 continue
             pr = gh.repos("ceph")("ceph").pulls(number).get()
             title = pr['title']
+            message = None
             message_lines = commit.message.split('\n')
             if not strict and len(message_lines) > 1:
                 lines = []
@@ -138,21 +139,19 @@ def make_release_notes(gh, repo, ref, plaintext, verbose, strict, use_tags):
                     line = line.strip()
                     if line:
                         lines.append(line)
+                if len(lines) == 0:
+                    continue
                 duplicates_pr_title = lines[0] == pr['title'].strip()
                 if duplicates_pr_title:
-                    lines.pop(0)
-                if len(lines) == 0:
-                    if duplicates_pr_title:
-                        message = None
-                elif len(lines) == 1:
+                    continue
+                assert len(lines) > 0, "missing message content"
+                if len(lines) == 1:
                     # assume that a single line means the intention is to
                     # re-write the PR title
                     title = lines[0]
                     message = None
                 else:
                     message = "    " + "\n    ".join(lines)
-            else:
-                message = None
             issues = []
             if pr['body']:
                 issues = fixes_re.findall(pr['body']) + tracker_re.findall(