From: Lukas Bezdicka Date: Wed, 19 Apr 2023 11:16:49 +0000 (+0200) Subject: Replace ip_version check with ansible test X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=d5e55516f47f9379137565bebbb43538bf60a1e8;p=ceph-ansible.git Replace ip_version check with ansible test Instead of checking ip_version variable we should check the input address for ip version and select code path based on that. This solves ceph adoption with mixed ipv6 and ipv4 networks. Resolves: rhbz#2186226 Signed-off-by: Lukas Bezdicka (cherry picked from commit 5622a033a9f8a5c32fdd9429f40599d6b37cd7ac) --- diff --git a/infrastructure-playbooks/cephadm-adopt.yml b/infrastructure-playbooks/cephadm-adopt.yml index e51545f78..ee3e39353 100644 --- a/infrastructure-playbooks/cephadm-adopt.yml +++ b/infrastructure-playbooks/cephadm-adopt.yml @@ -372,13 +372,13 @@ command: "{{ ceph_cmd }} orch host add {{ ansible_facts['nodename'] }} {{ ansible_facts['all_ipv4_addresses'] | ips_in_ranges(cephadm_mgmt_network.split(',')) | first }} {{ group_names | intersect(adopt_label_group_names) | join(' ') }}" changed_when: false delegate_to: '{{ groups[mon_group_name][0] }}' - when: ip_version == 'ipv4' + when: cephadm_mgmt_network is ansible.utils.ipv4 - name: manage nodes with cephadm - ipv6 command: "{{ ceph_cmd }} orch host add {{ ansible_facts['nodename'] }} {{ ansible_facts['all_ipv6_addresses'] | ips_in_ranges(cephadm_mgmt_network.split(',')) | last | ansible.utils.ipwrap }} {{ group_names | intersect(adopt_label_group_names) | join(' ') }}" changed_when: false delegate_to: '{{ groups[mon_group_name][0] }}' - when: ip_version == 'ipv6' + when: cephadm_mgmt_network is ansible.utils.ipv6 - name: add ceph label for core component command: "{{ ceph_cmd }} orch host label add {{ ansible_facts['nodename'] }} ceph"