From: Ramana Raja Date: Mon, 30 Oct 2023 15:05:27 +0000 (-0400) Subject: mgr/rbd_support: remove CreateSnapshotRequests __del__() X-Git-Tag: v17.2.8~640^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=d773346f5b1300868bca26abe6f2e8a60b7f5411;p=ceph.git mgr/rbd_support: remove CreateSnapshotRequests __del__() There is no need for CreateSnapshotRequests.__del__() that calls CreateSnapshotRequests.wait_for_pending(). MirrorSnapshotScheduleHandler.shutdown() already calls CreateSnapshotRequests.wait_for_pending(). Signed-off-by: Ramana Raja (cherry picked from commit fed1e87685a698876cf167b3681327e5b0066ee6) --- diff --git a/src/pybind/mgr/rbd_support/mirror_snapshot_schedule.py b/src/pybind/mgr/rbd_support/mirror_snapshot_schedule.py index 58cb3ce9e1fc..2f98f294c5ff 100644 --- a/src/pybind/mgr/rbd_support/mirror_snapshot_schedule.py +++ b/src/pybind/mgr/rbd_support/mirror_snapshot_schedule.py @@ -42,9 +42,6 @@ class CreateSnapshotRequests: self.queue: List[ImageSpec] = [] self.ioctxs: Dict[Tuple[str, str], Tuple[rados.Ioctx, Set[ImageSpec]]] = {} - def __del__(self) -> None: - self.wait_for_pending() - def wait_for_pending(self) -> None: with self.lock: while self.pending: