From: Abhishek Lekshmanan Date: Mon, 26 Oct 2020 17:36:25 +0000 (+0100) Subject: rgw: role/svc cosmetic comments & ws cleanup X-Git-Tag: v18.0.0~710^2~17 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=d8c2a893b38dde969b2f976fdc453c516aa21b60;p=ceph.git rgw: role/svc cosmetic comments & ws cleanup Signed-off-by: Abhishek Lekshmanan --- diff --git a/src/rgw/rgw_role.h b/src/rgw/rgw_role.h index fed1bfc67f57..ffb48e2bf182 100644 --- a/src/rgw/rgw_role.h +++ b/src/rgw/rgw_role.h @@ -216,6 +216,12 @@ public: bool from_remote_zone) override; }; +/// Defines control classes that call the low level service layer that handles +/// storage, svc classes implement the low level object operations. Ctl classes +/// can span over multiple service classes, for eg. User Ctl classes need to +/// update the user indices when buckets are added/removed RoleCtl classes may +/// need to update the RGW Account class that a role has been added deleted +/// under an account. class RGWRoleCtl { struct Svc { RGWSI_Role *role {nullptr}; diff --git a/src/rgw/services/svc_role.h b/src/rgw/services/svc_role.h index 4cd68ce18841..037b22c0632e 100644 --- a/src/rgw/services/svc_role.h +++ b/src/rgw/services/svc_role.h @@ -70,7 +70,7 @@ class RGWSI_Role: public RGWServiceInstance virtual int read_info(RGWSI_MetaBackend::Context *ctx, const std::string& role_id, - rgw::sal::RGWRole *role, + rgw::sal::RGWRole *role, // out param RGWObjVersionTracker * const objv_tracker, real_time * const pmtime, std::map * pattrs, @@ -122,10 +122,10 @@ class RGWSI_Role: public RGWServiceInstance const DoutPrefixProvider *dpp) = 0; virtual int list_roles_by_path_prefix(RGWSI_MetaBackend::Context *ctx, - const std::string& path, - const std::string& tenant, - std::vector& roles, - optional_yield y, + const std::string& path, + const std::string& tenant, + std::vector& roles, // out param + optional_yield y, const DoutPrefixProvider *dpp) = 0; };