From: Kefu Chai Date: Wed, 27 May 2026 08:52:31 +0000 (+0800) Subject: crimson/seastore: segment_manager: fix -Wunused warnings X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=d8f566925fed5d9fb9a2331baad742b9fdf55cf3;p=ceph.git crimson/seastore: segment_manager: fix -Wunused warnings 7f739adae2 dropped the last log call from get_segment_manager(), after which `LOG_PREFIX(SegmentManager::get_segment_manager)` and `SET_SUBSYS(seastore_device)` had no remaining users under `HAVE_ZNS`, generating: ``` src/crimson/os/seastore/segment_manager.cc:38:3: warning: unused variable 'FNAME' [-Wunused-variable] 38 | LOG_PREFIX(SegmentManager::get_segment_manager); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/crimson/common/log.h:49:38: note: expanded from macro 'LOG_PREFIX' 49 | #define LOG_PREFIX(x) constexpr auto FNAME = #x | ^~~~~ src/crimson/os/seastore/segment_manager.cc:10:1: warning: unused variable 'SOURCE_SUBSYS' [-Wunused-const-variable] 10 | SET_SUBSYS(seastore_device); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ src/crimson/common/log.h:46:52: note: expanded from macro 'SET_SUBSYS' 46 | #define SET_SUBSYS(subname_) static constexpr auto SOURCE_SUBSYS = ceph_subsys_##subname_ | ^~~~~~~~~~~~~ 2 warnings generated. ``` drop both to silence them. Signed-off-by: Kefu Chai --- diff --git a/src/crimson/os/seastore/segment_manager.cc b/src/crimson/os/seastore/segment_manager.cc index 501137a5835a..c99de668e1ff 100644 --- a/src/crimson/os/seastore/segment_manager.cc +++ b/src/crimson/os/seastore/segment_manager.cc @@ -7,7 +7,6 @@ #ifdef HAVE_ZNS #include "crimson/os/seastore/segment_manager/zbd.h" -SET_SUBSYS(seastore_device); #endif @@ -35,7 +34,6 @@ SegmentManager::get_segment_manager( { const std::string device_block = device + "/block"; #ifdef HAVE_ZNS - LOG_PREFIX(SegmentManager::get_segment_manager); if (dtype == device_type_t::ZBD) { co_return std::make_unique( device_block);