From: Yehuda Sadeh Date: Thu, 18 Feb 2016 23:20:20 +0000 (-0800) Subject: rgw: silence compilation #warnings X-Git-Tag: v10.1.0~354^2~7 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=d95fcfa5448f69240d0ed478e2ef4de02f7ef25b;p=ceph.git rgw: silence compilation #warnings these are now FIXMEs Signed-off-by: Yehuda Sadeh --- diff --git a/src/rgw/rgw_admin.cc b/src/rgw/rgw_admin.cc index cb4730b1a777..fb4c2a927b91 100644 --- a/src/rgw/rgw_admin.cc +++ b/src/rgw/rgw_admin.cc @@ -2772,8 +2772,6 @@ int main(int argc, char **argv) return -ret; } - #warning need to implement for backward compatabilty - if (reset_regions) { zonegroupmap.zonegroups.clear(); } diff --git a/src/rgw/rgw_data_sync.cc b/src/rgw/rgw_data_sync.cc index 2243426d873c..5d8c72f21e54 100644 --- a/src/rgw/rgw_data_sync.cc +++ b/src/rgw/rgw_data_sync.cc @@ -484,7 +484,7 @@ public: oid_prefix); yield { string entrypoint = string("/admin/metadata/bucket.instance"); -#warning need a better scaling solution here, requires streaming output + /* FIXME: need a better scaling solution here, requires streaming output */ call(new RGWReadRESTResourceCR >(store->ctx(), sync_env->conn, sync_env->http_manager, entrypoint, NULL, &result)); } @@ -694,7 +694,7 @@ public: yield call(sync_env->error_logger->log_error_cr(sync_env->conn->get_remote_id(), "data", bucket_name + ":" + bucket_instance, -sync_status, string("failed to sync bucket instance: ") + cpp_strerror(-sync_status))); } -#warning what do do in case of error + /* FIXME: what do do in case of error */ if (!entry_marker.empty()) { /* update marker */ yield call(marker_tracker->finish(entry_marker)); diff --git a/src/rgw/rgw_sync.cc b/src/rgw/rgw_sync.cc index f17e1e3ab001..fbf3e56889b9 100644 --- a/src/rgw/rgw_sync.cc +++ b/src/rgw/rgw_sync.cc @@ -659,7 +659,7 @@ public: for (; sections_iter != sections.end(); ++sections_iter) { yield { string entrypoint = string("/admin/metadata/") + *sections_iter; -#warning need a better scaling solution here, requires streaming output + /* FIXME: need a better scaling solution here, requires streaming output */ call(new RGWReadRESTResourceCR >(cct, conn, sync_env->http_manager, entrypoint, NULL, &result)); } @@ -963,7 +963,7 @@ int RGWMetaSyncSingleEntryCR::operate() { sync_status = retcode; if (sync_status == -ENOENT) { -#warning remove entry from local + /* FIXME: do we need to remove the entry from the local zone? */ break; }