From: Sebastian Wagner <sebastian.wagner@suse.com>
Date: Wed, 22 Apr 2020 14:10:27 +0000 (+0200)
Subject: mgr/cephadm: use check_call  for `ssh-keygen`
X-Git-Tag: v15.2.2~38^2~11
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=da93bedeb8b5b5e6e9abbc296686061ae1efe9c3;p=ceph.git

mgr/cephadm: use check_call  for `ssh-keygen`

Mainly to provide any reasonable error

Fixes: https://tracker.ceph.com/issues/44832
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit 370bddb301ff3d2da59c4cdc6b7eaed44a8cd488)
---

diff --git a/src/pybind/mgr/cephadm/module.py b/src/pybind/mgr/cephadm/module.py
index 2a1ff2db6421..130377ecdc57 100644
--- a/src/pybind/mgr/cephadm/module.py
+++ b/src/pybind/mgr/cephadm/module.py
@@ -1424,7 +1424,7 @@ class CephadmOrchestrator(orchestrator.Orchestrator, MgrModule):
             tmp_dir = TemporaryDirectory()
             path = tmp_dir.name + '/key'
             try:
-                subprocess.call([
+                subprocess.check_call([
                     '/usr/bin/ssh-keygen',
                     '-C', 'ceph-%s' % self._cluster_fsid,
                     '-N', '',