From: Yehuda Sadeh <yehuda@redhat.com>
Date: Tue, 21 Jan 2020 21:20:30 +0000 (-0800)
Subject: rgw: fix a potential leak
X-Git-Tag: v15.1.0~22^2~13
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=db1a7335b11df069fee32f7e0d7c6de48e174d3e;p=ceph.git

rgw: fix a potential leak

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
---

diff --git a/src/rgw/services/svc_zone.cc b/src/rgw/services/svc_zone.cc
index 404937574c968..770cf98384929 100644
--- a/src/rgw/services/svc_zone.cc
+++ b/src/rgw/services/svc_zone.cc
@@ -169,13 +169,13 @@ int RGWSI_Zone::do_start()
   zone_short_id = current_period->get_map().get_zone_short_id(zone_params->get_id());
 
   for (auto ziter : zonegroup->zones) {
-    auto zone_handler = new RGWBucketSyncPolicyHandler(this, sync_modules_svc, bucket_sync_svc, ziter.second.id);
+    auto zone_handler = std::make_shared<RGWBucketSyncPolicyHandler>(this, sync_modules_svc, bucket_sync_svc, ziter.second.id);
     ret = zone_handler->init(null_yield);
     if (ret < 0) {
       lderr(cct) << "ERROR: could not initialize zone policy handler for zone=" << ziter.second.name << dendl;
       return ret;
       }
-    sync_policy_handlers[ziter.second.id].reset(zone_handler);
+    sync_policy_handlers[ziter.second.id] = zone_handler;
   }
 
   sync_policy_handler = sync_policy_handlers[zone_id()]; /* we made sure earlier that zonegroup->zones has our zone */