From: xie xingguo <xie.xingguo@zte.com.cn>
Date: Sat, 7 Sep 2019 01:24:37 +0000 (+0800)
Subject: os/bluestore: add bluestore_bluefs_max_free option
X-Git-Tag: v15.1.0~1608^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=dbcde2daf4403ec285918c4e9535980d912bea7f;p=ceph.git

os/bluestore: add bluestore_bluefs_max_free option

This prevents bluefs from trying to acquire more space than
it actually needs, e.g., due to batch deletion of user data.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
---

diff --git a/src/common/options.cc b/src/common/options.cc
index f28d94f837c1..7f1297b7d90b 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -4359,6 +4359,10 @@ std::vector<Option> get_global_options() {
     .set_default(1_G)
     .set_description("minimum free space allocated to BlueFS"),
 
+    Option("bluestore_bluefs_max_free", Option::TYPE_SIZE, Option::LEVEL_ADVANCED)
+    .set_default(10_G)
+    .set_description("Maximum free space allocated to BlueFS"),
+
     Option("bluestore_bluefs_min_ratio", Option::TYPE_FLOAT, Option::LEVEL_ADVANCED)
     .set_default(.02)
     .set_description("Minimum fraction of free space devoted to BlueFS"),
diff --git a/src/os/bluestore/BlueStore.cc b/src/os/bluestore/BlueStore.cc
index 40f29fcf7815..d4358b47a484 100644
--- a/src/os/bluestore/BlueStore.cc
+++ b/src/os/bluestore/BlueStore.cc
@@ -5807,7 +5807,8 @@ int64_t BlueStore::_get_bluefs_size_delta(uint64_t bluefs_free, uint64_t bluefs_
       gift = g;
     reclaim = 0;
   }
-  uint64_t min_free = cct->_conf.get_val<Option::size_t>("bluestore_bluefs_min_free");
+  uint64_t min_free =
+    cct->_conf.get_val<Option::size_t>("bluestore_bluefs_min_free");
   if (bluefs_free < min_free &&
       min_free < free_cap) {
     uint64_t g = min_free - bluefs_free;
@@ -5818,6 +5819,14 @@ int64_t BlueStore::_get_bluefs_size_delta(uint64_t bluefs_free, uint64_t bluefs_
       gift = g;
     reclaim = 0;
   }
+  uint64_t max_free =
+    cct->_conf.get_val<Option::size_t>("bluestore_bluefs_max_free");
+  if (bluefs_free > max_free) {
+    dout(10) << __func__ << " bluefs_free " << bluefs_free
+             << " > max " << max_free
+             << ", stop gifting for now" << dendl;
+    gift = 0;
+  }
   ceph_assert((int64_t)gift >= 0);
   ceph_assert((int64_t)reclaim >= 0);
   return gift > 0 ? (int64_t)gift : -(int64_t)reclaim;