From: Xuehan Xu <xuxuehan@qianxin.com>
Date: Fri, 9 Aug 2024 05:25:35 +0000 (+0800)
Subject: crimson/osd/pg: fix wrong lambda capture of transactions in
X-Git-Tag: testing/wip-mchangir-testing-20240905.063159-main-debug~9^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=dd10b32b61eb864d3a947c6e9c62cfd658ed4e67;p=ceph-ci.git

crimson/osd/pg: fix wrong lambda capture of transactions in
`PG::submit_error_log()`

Fixes: https://tracker.ceph.com/issues/67450
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
---

diff --git a/src/crimson/osd/pg.cc b/src/crimson/osd/pg.cc
index bb249b8e10e..9c853fa6bc3 100644
--- a/src/crimson/osd/pg.cc
+++ b/src/crimson/osd/pg.cc
@@ -1121,10 +1121,10 @@ seastar::future<std::optional<eversion_t>> PG::submit_error_log(
     log_entries, t, peering_state.get_pg_trim_to(),
     peering_state.get_min_last_complete_ondisk());
 
-  return seastar::do_with(log_entries, t, set<pg_shard_t>{},
-    [this, rep_tid](auto& log_entries, auto& t,auto& waiting_on) mutable {
+  return seastar::do_with(log_entries, set<pg_shard_t>{},
+    [this, t=std::move(t), rep_tid](auto& log_entries, auto& waiting_on) mutable {
     return seastar::do_for_each(get_acting_recovery_backfill(),
-      [this, log_entries, t=std::move(t), waiting_on, rep_tid]
+      [this, log_entries, waiting_on, rep_tid]
       (auto& i) mutable {
       pg_shard_t peer(i);
       if (peer == pg_whoami) {