From: Matan Breizman Date: Wed, 8 Jul 2026 11:21:08 +0000 (+0000) Subject: crimson/os/seastore: drop sub-ms do_transaction latency buckets X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=dd9cdd7293eb499574047563c214fa4c0d259898;p=ceph.git crimson/os/seastore: drop sub-ms do_transaction latency buckets The do_transaction latency histograms now source their samples from seastar::lowres_clock (~0.5ms default). Drop the sub 1ms buckets. Signed-off-by: Matan Breizman --- diff --git a/src/crimson/os/seastore/seastore.h b/src/crimson/os/seastore/seastore.h index c261eb86352..45eb52257a7 100644 --- a/src/crimson/os/seastore/seastore.h +++ b/src/crimson/os/seastore/seastore.h @@ -440,10 +440,12 @@ public: static constexpr auto LAT_MAX = static_cast(op_type_t::MAX); - // Histogram bucket upper bounds in microseconds (0.25ms–20ms). - // Ops above 20ms land in the last bucket as overflow. - static constexpr std::array lat_hist_bounds_us = { - 250, 500, 1000, + // Histogram bucket upper bounds in microseconds (1ms–100ms). + // Ops above 100ms land in the last bucket as overflow. The smallest + // bucket is 1ms: sub-ms latencies are below lowres_clock resolution + // (~task_quota) and cannot be resolved, so no finer buckets are kept. + static constexpr std::array lat_hist_bounds_us = { + 1000, 1500, 2000, 3000, 5000, 7500, 10000, @@ -456,9 +458,11 @@ public: static constexpr std::size_t REPLAY_BUCKETS = 16; static constexpr auto STAGE_MAX = static_cast(txn_stage_t::MAX); - // Upper bounds (microseconds) for the per-stage do_transaction latency histograms - static constexpr std::array STAGE_LAT_BUCKETS_US = { - 250, 500, 1000, 1500, 2000, 3000, 5000, 7500, + // Upper bounds (microseconds) for the per-stage do_transaction latency + // histograms. Smallest bucket is 1ms; sub-ms is below lowres_clock + // resolution (~task_quota) and cannot be resolved. + static constexpr std::array STAGE_LAT_BUCKETS_US = { + 1000, 1500, 2000, 3000, 5000, 7500, 10000, 15000, 20000, 30000, 50000, 100000 };