From: Sage Weil <sage@redhat.com>
Date: Fri, 2 Jun 2017 14:31:41 +0000 (-0400)
Subject: pybind/mgr/restful: prefix commands with 'restful'
X-Git-Tag: v12.1.0~213^2~5
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=de6af1b2f43a101539b9f15908ffd4aae1d5fd20;p=ceph.git

pybind/mgr/restful: prefix commands with 'restful'

And use - instead of _, following the ceph convention.

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/pybind/mgr/restful/api/__init__.py b/src/pybind/mgr/restful/api/__init__.py
index a6c662a2ca1..d4345eebc64 100644
--- a/src/pybind/mgr/restful/api/__init__.py
+++ b/src/pybind/mgr/restful/api/__init__.py
@@ -30,7 +30,7 @@ class Root(RestController):
         return {
             'api_version': 1,
             'auth':
-                'Use "ceph tell mgr create_key <key>" to create a key pair, '
+                'Use "ceph tell mgr restful create_key <key>" to create a key pair, '
                 'pass it as HTTP Basic auth to authenticate',
             'doc': 'See /doc endpoint',
             'info': "Ceph Manager RESTful API server",
diff --git a/src/pybind/mgr/restful/module.py b/src/pybind/mgr/restful/module.py
index adfefd098a9..e41c55e2457 100644
--- a/src/pybind/mgr/restful/module.py
+++ b/src/pybind/mgr/restful/module.py
@@ -198,17 +198,17 @@ class CommandsRequest(object):
 class Module(MgrModule):
     COMMANDS = [
         {
-            "cmd": "create_key name=key_name,type=CephString",
+            "cmd": "restful create-key name=key_name,type=CephString",
             "desc": "Create an API key with this name",
             "perm": "rw"
         },
         {
-            "cmd": "delete_key name=key_name,type=CephString",
+            "cmd": "restful delete-key name=key_name,type=CephString",
             "desc": "Delete an API key with this name",
             "perm": "rw"
         },
         {
-            "cmd": "list_keys",
+            "cmd": "restful list-keys",
             "desc": "List all API keys",
             "perm": "rw"
         },
@@ -326,7 +326,7 @@ class Module(MgrModule):
 
     def handle_command(self, command):
         self.log.warn("Handling command: '%s'" % str(command))
-        if command['prefix'] == "create_key":
+        if command['prefix'] == "restful create-key":
             if command['key_name'] in self.keys:
                 return 0, self.keys[command['key_name']], ""
 
@@ -340,7 +340,7 @@ class Module(MgrModule):
                 "",
             )
 
-        elif command['prefix'] == "delete_key":
+        elif command['prefix'] == "restful delete-key":
             if command['key_name'] in self.keys:
                 del self.keys[command['key_name']]
                 self.set_config_json('keys', self.keys)
@@ -351,7 +351,7 @@ class Module(MgrModule):
                 "",
             )
 
-        elif command['prefix'] == "list_keys":
+        elif command['prefix'] == "restful list-keys":
             return (
                 0,
                 json.dumps(self.get_config_json('keys'), indent=2),
diff --git a/src/vstart.sh b/src/vstart.sh
index f48fdfbea97..fcd727fdc84 100755
--- a/src/vstart.sh
+++ b/src/vstart.sh
@@ -653,7 +653,7 @@ EOF
     done
 
     SF=`mktemp`
-    ceph_adm --debug-ms 1 tell mgr.x create_key admin -o $SF
+    ceph_adm tell mgr.x restful create-key admin -o $SF
     RESTFUL_SECRET=`cat $SF`
     rm $SF
 }