From: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
Date: Wed, 5 May 2021 16:11:03 +0000 (+0200)
Subject: Merge pull request #40063 from rhcs-dashboard/cyclomatic-complexity
X-Git-Tag: v17.1.0~2066
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=de6ee222603175710371b160ced631ca76500571;p=ceph-ci.git

Merge pull request #40063 from rhcs-dashboard/cyclomatic-complexity

mgr/dashboard: reduce cyclomatic complexity

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
---

de6ee222603175710371b160ced631ca76500571
diff --cc src/pybind/mgr/dashboard/tests/test_sso.py
index ab565137a18,b14c6add15a..c347f542008
--- a/src/pybind/mgr/dashboard/tests/test_sso.py
+++ b/src/pybind/mgr/dashboard/tests/test_sso.py
@@@ -3,13 -3,16 +3,14 @@@
  from __future__ import absolute_import
  
  import errno
+ import tempfile
  import unittest
  
 -from ..services.sso import handle_sso_command, load_sso_db
 -from . import CmdException  # pylint: disable=no-name-in-module
 -from . import KVStoreMockMixin  # pylint: disable=no-name-in-module
 -from . import exec_dashboard_cmd  # pylint: disable=no-name-in-module
 +from ..services.sso import load_sso_db
 +from . import CLICommandTestMixin, CmdException  # pylint: disable=no-name-in-module
  
  
 -class AccessControlTest(unittest.TestCase, KVStoreMockMixin):
 +class AccessControlTest(unittest.TestCase, CLICommandTestMixin):
      IDP_METADATA = '''<?xml version="1.0"?>
  <md:EntityDescriptor xmlns:md="urn:oasis:names:tc:SAML:2.0:metadata"
                       xmlns:ds="http://www.w3.org/2000/09/xmldsig#"