From: Radoslaw Zarzynski <rzarzyns@redhat.com>
Date: Wed, 24 Jun 2020 13:40:53 +0000 (+0000)
Subject: crimson, common: switch bs_rocksdb_cf validator to strict_strtob().
X-Git-Tag: v16.1.0~1901^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=deadeb87d99a0f2cbded0c8e1812c3b8aff97e78;p=ceph.git

crimson, common: switch bs_rocksdb_cf validator to strict_strtob().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
---

diff --git a/src/common/options.cc b/src/common/options.cc
index e4b58f6b1e89..cfdbb74d6097 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -4432,12 +4432,14 @@ std::vector<Option> get_global_options() {
     // RocksDB sharding in BlueStore dramatically lifted the number of
     // threads spawn during RocksDB's init.
     .set_validator([](std::string *value, std::string *error_message){
-      if (*value != "false") {
+      if (const bool parsed_value = strict_strtob(value->c_str(), error_message);
+	  error_message->empty() && parsed_value) {
         *error_message = "invalid BlueStore sharding configuration."
                          " Be aware any change takes effect only on mkfs!";
         return -EINVAL;
+      } else {
+        return 0;
       }
-      return 0;
     })
 #endif
     .set_description("Enable use of rocksdb column families for bluestore metadata"),