From: Yingxin Cheng <yingxin.cheng@intel.com>
Date: Tue, 27 Jul 2021 08:50:52 +0000 (+0800)
Subject: crimson/os/seastore/cache: remove derived metrics
X-Git-Tag: v17.1.0~1254^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=dedd14e18517cb1d01f5090a2496a7bb7b50299d;p=ceph-ci.git

crimson/os/seastore/cache: remove derived metrics

Only keep the basic metrics to minimize the total number of metrics.

Derived metrics can be numerous according to different needs and can be
confusing with labels.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
---

diff --git a/src/crimson/os/seastore/cache.cc b/src/crimson/os/seastore/cache.cc
index 82a5712fef4..2dcd4026905 100644
--- a/src/crimson/os/seastore/cache.cc
+++ b/src/crimson/os/seastore/cache.cc
@@ -137,24 +137,6 @@ void Cache::register_metrics()
     register_trans_created(src);
   }
 
-  metrics.add_group(
-    "cache",
-    {
-      sm::make_counter(
-        "trans_created",
-        [this] {
-          uint64_t total = 0;
-          for (auto& v : stats.trans_created_by_src) {
-            total += v;
-          }
-          return total;
-        },
-        sm::description("total number of transaction created"),
-        {src_label("ALL")}
-      ),
-    }
-  );
-
   /*
    * trans_committed
    */
@@ -183,24 +165,6 @@ void Cache::register_metrics()
     register_trans_committed(src);
   }
 
-  metrics.add_group(
-    "cache",
-    {
-      sm::make_counter(
-        "trans_committed",
-        [this] {
-          uint64_t total = 0;
-          for (auto& v : stats.trans_committed_by_src) {
-            total += v;
-          }
-          return total;
-        },
-        sm::description("total number of transaction committed"),
-        {src_label("ALL")}
-      ),
-    }
-  );
-
   /*
    * trans_invalidated
    */