From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Tue, 3 Feb 2015 21:34:34 +0000 (+0100)
Subject: XioMessenger.cc: fix dead pointer usage
X-Git-Tag: suse_latest~36^2~9^2~3
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=df161d32f1f05d321504c715c583cda1d0e805d3;p=ceph.git

XioMessenger.cc: fix dead pointer usage

Move _addr to upper scope to prevent dead pointer 'a' after
assignment of _addr in if-clause.

Fix for:

[src/msg/xio/XioMessenger.cc:669]: (error) Dead pointer usage.
Pointer 'a' is dead if it has been assigned '&_addr' at line 644

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/msg/xio/XioMessenger.cc b/src/msg/xio/XioMessenger.cc
index 1b9ea7c31227..44ab40ba98ba 100644
--- a/src/msg/xio/XioMessenger.cc
+++ b/src/msg/xio/XioMessenger.cc
@@ -639,8 +639,9 @@ xio_place_buffers(buffer::list& bl, XioMsg *xmsg, struct xio_msg*& req,
 int XioMessenger::bind(const entity_addr_t& addr)
 {
   const entity_addr_t *a = &addr;
+  struct entity_addr_t _addr = *a;
+
   if (a->is_blank_ip()) {
-    struct entity_addr_t _addr = *a;
     a = &_addr;
     std::vector <std::string> my_sections;
     g_conf->get_my_sections(my_sections);