From: Greg Farnum <gregf@hq.newdream.net>
Date: Tue, 11 May 2010 17:22:14 +0000 (-0700)
Subject: mds: locking. remove zero-valued client held/waiting lock counts from the map.
X-Git-Tag: v0.22~346^2~17
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=df813369d380d12a047b21ec36ecb8aadb685940;p=ceph.git

mds: locking. remove zero-valued client held/waiting lock counts from the map.

In the unlikely event that you have a very large cluster doing a lot of
locking of different files amongst the whole cluster, this will keep
memory use down.
---

diff --git a/src/mds/mdstypes.h b/src/mds/mdstypes.h
index dc06d2e3b67d..4ab9532fb0b1 100644
--- a/src/mds/mdstypes.h
+++ b/src/mds/mdstypes.h
@@ -476,6 +476,9 @@ struct ceph_lock_state_t {
 	  --client_held_lock_counts[old_lock->client];
 	}
       }
+      if (!client_held_lock_counts.count(old_lock->client)) {
+	client_held_lock_counts.erase(old_lock->client);
+      }
     }
 
     /* okay, we've removed the locks, but removing them might allow some
@@ -496,6 +499,9 @@ struct ceph_lock_state_t {
 	ceph_filelock cur_lock = *(*iter);
 	waiting_locks.erase(find_specific_elem(*iter, waiting_locks));
 	--client_waiting_lock_counts[cur_lock.client];
+	if (!client_waiting_lock_counts.count(cur_lock.client)) {
+	  client_waiting_lock_counts.erase(cur_lock.client);
+	}
 	if(add_lock(cur_lock, true)) activated_locks.push_back(cur_lock);
       }
     }
@@ -505,12 +511,12 @@ struct ceph_lock_state_t {
     bool cleared_any = false;
     if (client_held_lock_counts.count(client)) {
       remove_all_from(client, held_locks);
-      client_held_lock_counts[client] = 0;
+      client_held_lock_counts.erase(client);
       cleared_any = true;
     }
     if (client_waiting_lock_counts.count(client)) {
       remove_all_from(client, waiting_locks);
-      client_waiting_lock_counts[client] = 0;
+      client_waiting_lock_counts.erase(client);
     }
     return cleared_any;
   }
@@ -607,6 +613,9 @@ private:
 	  }
 	}
       }
+      if (!client_held_lock_counts.count(old_lock->client)) {
+	client_held_lock_counts.erase(old_lock->client);
+      }
     }
   }