From: Samuel Just <sjust@redhat.com>
Date: Thu, 25 Feb 2021 05:45:21 +0000 (-0800)
Subject: crimson/os: remove FuturizedStore::OmapIterator::tail_key
X-Git-Tag: v17.1.0~2678^2~5
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=dfb017b686964343cf1535b00636ea638f6c147d;p=ceph.git

crimson/os: remove FuturizedStore::OmapIterator::tail_key

This doesn't actually make sense for FuturzizedStore implementations other
than BlueStore, and then only in a diagnostic capacity.  It also doesn't
have any actual users at the moment.

Signed-off-by: Samuel Just <sjust@redhat.com>
---

diff --git a/src/crimson/os/alienstore/alien_store.cc b/src/crimson/os/alienstore/alien_store.cc
index 5bde60f8fdb..827d9f9af29 100644
--- a/src/crimson/os/alienstore/alien_store.cc
+++ b/src/crimson/os/alienstore/alien_store.cc
@@ -557,13 +557,6 @@ std::string AlienStore::AlienOmapIterator::key()
   return iter->key();
 }
 
-seastar::future<std::string> AlienStore::AlienOmapIterator::tail_key()
-{
-  return store->tp->submit([this] {
-    return iter->tail_key();
-  });
-}
-
 ceph::buffer::list AlienStore::AlienOmapIterator::value()
 {
   return iter->value();
diff --git a/src/crimson/os/alienstore/alien_store.h b/src/crimson/os/alienstore/alien_store.h
index 8e67d08f24e..ae4830981e6 100644
--- a/src/crimson/os/alienstore/alien_store.h
+++ b/src/crimson/os/alienstore/alien_store.h
@@ -31,7 +31,6 @@ public:
     bool valid() const;
     seastar::future<> next();
     std::string key();
-    seastar::future<std::string> tail_key();
     ceph::buffer::list value();
     int status() const;
   private:
diff --git a/src/crimson/os/cyanstore/cyan_store.h b/src/crimson/os/cyanstore/cyan_store.h
index 07a8ff29e7e..6d802152dc4 100644
--- a/src/crimson/os/cyanstore/cyan_store.h
+++ b/src/crimson/os/cyanstore/cyan_store.h
@@ -50,9 +50,6 @@ public:
     std::string key() final {
       return iter->first;
     }
-    virtual seastar::future<std::string> tail_key(){
-      return seastar::make_ready_future<std::string>((++obj->omap.end())->first);
-    }
     virtual ceph::buffer::list value() {
       return iter->second;
     }
diff --git a/src/crimson/os/futurized_store.h b/src/crimson/os/futurized_store.h
index 98ea7274b37..d7d9c6f133a 100644
--- a/src/crimson/os/futurized_store.h
+++ b/src/crimson/os/futurized_store.h
@@ -37,9 +37,6 @@ public:
     virtual std::string key() {
       return {};
     }
-    virtual seastar::future<std::string> tail_key() {
-      return seastar::make_ready_future<std::string>();
-    }
     virtual ceph::buffer::list value() {
       return {};
     }