From: Casey Bodley <cbodley@redhat.com>
Date: Tue, 7 Oct 2025 16:09:11 +0000 (-0400)
Subject: rgw/services: don't expose RGWServices::notify
X-Git-Tag: testing/wip-vshankar-testing-20251027.053005-debug~38^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=dfc379ccf31cb2b4a68d123af8af70b7aae0b377;p=ceph-ci.git

rgw/services: don't expose RGWServices::notify

RGWSI_Notify is only used internally by RGWSI_SysObj_Cache where the
dependency is injected to RGWSI_SysObj_Cache::init(). there's no need to
expose a pointer to RGWSI_Notify to the rest of the application,
especially now that it can be a nullptr

Signed-off-by: Casey Bodley <cbodley@redhat.com>
---

diff --git a/src/rgw/driver/rados/rgw_service.cc b/src/rgw/driver/rados/rgw_service.cc
index ec6d4aea052..b69ac11462c 100644
--- a/src/rgw/driver/rados/rgw_service.cc
+++ b/src/rgw/driver/rados/rgw_service.cc
@@ -282,7 +282,6 @@ int RGWServices::do_init(CephContext *_cct, rgw::sal::RadosStore* driver, bool h
   config_key = config_key_rados;
   datalog_rados = _svc.datalog_rados.get();
   mdlog = _svc.mdlog.get();
-  notify = _svc.notify.get();
   zone = _svc.zone.get();
   zone_utils = _svc.zone_utils.get();
   quota = _svc.quota.get();
diff --git a/src/rgw/driver/rados/rgw_service.h b/src/rgw/driver/rados/rgw_service.h
index 96fe99c367f..cdc2392da18 100644
--- a/src/rgw/driver/rados/rgw_service.h
+++ b/src/rgw/driver/rados/rgw_service.h
@@ -132,7 +132,6 @@ struct RGWServices
   RGWSI_ConfigKey *config_key{nullptr};
   RGWDataChangesLog *datalog_rados{nullptr};
   RGWSI_MDLog *mdlog{nullptr};
-  RGWSI_Notify *notify{nullptr};
   RGWSI_Zone *zone{nullptr};
   RGWSI_ZoneUtils *zone_utils{nullptr};
   RGWSI_Quota *quota{nullptr};