From: Nathan Cutler Date: Wed, 1 Aug 2018 10:33:58 +0000 (+0200) Subject: build/ops: unify command substitution in install-deps.sh X-Git-Tag: v14.0.1~671^2~1 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=e0042dd617269934bf51efee5bab7e4485875576;p=ceph-ci.git build/ops: unify command substitution in install-deps.sh The $() form is preferable to `` because folks (like me) might be using ` as a keyboard shortcut to GNU Screen, causing havoc to ensue whenever copy-pasting the ` character. Signed-off-by: Nathan Cutler --- diff --git a/install-deps.sh b/install-deps.sh index b6ad79a0718..bc7e2681ac0 100755 --- a/install-deps.sh +++ b/install-deps.sh @@ -21,7 +21,7 @@ if test $(id -u) != 0 ; then fi export LC_ALL=C # the following is vulnerable to i18n -ARCH=`uname -m` +ARCH=$(uname -m) function install_seastar_deps { if [ $WITH_SEASTAR ]; then @@ -135,7 +135,7 @@ EOF fi } -if [ x`uname`x = xFreeBSDx ]; then +if [ x$(uname)x = xFreeBSDx ]; then $SUDO pkg install -yq \ devel/babeltrace \ devel/git \