From: Jason Dillaman <dillaman@redhat.com>
Date: Wed, 31 May 2017 18:18:15 +0000 (-0400)
Subject: msg: do not enable client-side binding by default
X-Git-Tag: v12.1.0~256^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e06b4fca0ef3dbd72862e65c4d5a30b0ab196c0c;p=ceph.git

msg: do not enable client-side binding by default

This breaks the usage of Ceph clients connecting to MONs and
OSDs behind a NAT since the client will incorrectly attempt to
bind to the gateway's IP address.

Fixes: http://tracker.ceph.com/issues/20049
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
---

diff --git a/src/common/config_opts.h b/src/common/config_opts.h
index 476caad93d7..bbb07281ded 100644
--- a/src/common/config_opts.h
+++ b/src/common/config_opts.h
@@ -211,7 +211,7 @@ OPTION(ms_bind_retry_delay, OPT_INT, 5) // Delay between attemps to bind
 OPTION(ms_bind_retry_count, OPT_INT, 6) // If binding fails, how many times do we retry to bind
 OPTION(ms_bind_retry_delay, OPT_INT, 6) // Delay between attemps to bind
 #endif
-OPTION(ms_bind_before_connect, OPT_BOOL, true)
+OPTION(ms_bind_before_connect, OPT_BOOL, false)
 OPTION(ms_rwthread_stack_bytes, OPT_U64, 1024 << 10)
 OPTION(ms_tcp_read_timeout, OPT_U64, 900)
 OPTION(ms_pq_max_tokens_per_priority, OPT_U64, 16777216)