From: Andrey Zagrebin Date: Fri, 17 Aug 2018 17:51:30 +0000 (-0700) Subject: #3865 followup for fix performance degression introduced by switching order of operan... X-Git-Tag: rocksdb-5.14.3~1 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e12d15320af0089707ebc688ae0cc0b4515fe9b5;p=rocksdb.git #3865 followup for fix performance degression introduced by switching order of operands (#4284) Summary: Followup for #4266. There is one more place in **get_context.cc** where **MergeOperator::ShouldMerge** should be called with reversed list of operands. Pull Request resolved: https://github.com/facebook/rocksdb/pull/4284 Differential Revision: D9380008 Pulled By: sagar0 fbshipit-source-id: 70ec26e607e5b88465e1acbdcd6c6171bd76b9f2 --- diff --git a/table/get_context.cc b/table/get_context.cc index 2a90978c..6814e50b 100644 --- a/table/get_context.cc +++ b/table/get_context.cc @@ -200,7 +200,7 @@ bool GetContext::SaveValue(const ParsedInternalKey& parsed_key, merge_context_->PushOperand(value, false); } if (merge_operator_ != nullptr && - merge_operator_->ShouldMerge(merge_context_->GetOperands())) { + merge_operator_->ShouldMerge(merge_context_->GetOperandsDirectionBackward())) { state_ = kFound; if (LIKELY(pinnable_val_ != nullptr)) { Status merge_status = MergeHelper::TimedFullMerge(