From: yite.gu <yitegu0@gmail.com>
Date: Thu, 15 Jun 2023 03:35:23 +0000 (+0800)
Subject: common/TrackedOp: rename and raise prio of slow op perfcounter
X-Git-Tag: v20.0.0~1374^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e1a02841973f75c7302fd5088f5be74266fd15c4;p=ceph.git

common/TrackedOp: rename and raise prio of slow op perfcounter

1. TrackedOp is a common class, mon and mds alse use it.
2. Set prio level of l_trackedop_slow_op_count to PRIO_USEFUL,
   we can get change of slow op of daemon from prometheus metrics,
   it's very interesting

Signed-off-by: Yite Gu <yitegu0@gmail.com>
---

diff --git a/src/common/TrackedOp.cc b/src/common/TrackedOp.cc
index d63bdb8f9a5..80d03b1aca9 100644
--- a/src/common/TrackedOp.cc
+++ b/src/common/TrackedOp.cc
@@ -90,7 +90,7 @@ void OpHistory::_insert_delayed(const utime_t& now, TrackedOpRef op)
   arrived.insert(make_pair(op->get_initiated(), op));
   if (opduration >= history_slow_op_threshold.load()) {
     slow_op.insert(make_pair(op->get_initiated(), op));
-    logger->inc(l_osd_slow_op_count);
+    logger->inc(l_trackedop_slow_op_count);
   }
   cleanup(now);
 }
diff --git a/src/common/TrackedOp.h b/src/common/TrackedOp.h
index 0ff7430b372..da5991e3011 100644
--- a/src/common/TrackedOp.h
+++ b/src/common/TrackedOp.h
@@ -52,9 +52,9 @@ public:
 };
 
 enum {
-  l_osd_slow_op_first = 1000,
-  l_osd_slow_op_count,
-  l_osd_slow_op_last,
+  l_trackedop_slow_op_first = 1000,
+  l_trackedop_slow_op_count,
+  l_trackedop_slow_op_last,
 };
 
 class OpHistory {
@@ -75,9 +75,11 @@ class OpHistory {
 
 public:
   OpHistory(CephContext *c) : cct(c), opsvc(this) {
-    PerfCountersBuilder b(cct, "osd-slow-ops",
-                         l_osd_slow_op_first, l_osd_slow_op_last);
-    b.add_u64_counter(l_osd_slow_op_count, "slow_ops_count",
+    PerfCountersBuilder b(cct, "trackedop",
+                         l_trackedop_slow_op_first, l_trackedop_slow_op_last);
+    b.set_prio_default(PerfCountersBuilder::PRIO_USEFUL);
+
+    b.add_u64_counter(l_trackedop_slow_op_count, "slow_ops_count",
                       "Number of operations taking over ten second");
 
     logger.reset(b.create_perf_counters());