From: Sage Weil <sage@inktank.com>
Date: Wed, 29 May 2013 15:34:13 +0000 (-0700)
Subject: os/LevelDBStore: allow compaction of key ranges
X-Git-Tag: v0.64~35^2~5
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e20c9a3f79ccfeb816ed634ca25de29fc5975ea8;p=ceph.git

os/LevelDBStore: allow compaction of key ranges

Signed-off-by: Sage Weil <sage@inktank.com>
---

diff --git a/src/os/LevelDBStore.cc b/src/os/LevelDBStore.cc
index 10238a7d98b2..2f1ea53e9a59 100644
--- a/src/os/LevelDBStore.cc
+++ b/src/os/LevelDBStore.cc
@@ -147,10 +147,10 @@ void LevelDBStore::compact_thread_entry()
   compact_queue_lock.Lock();
   while (!compact_queue_stop) {
     while (!compact_queue.empty()) {
-      string prefix = compact_queue.front();
+      pair<string,string> range = compact_queue.front();
       compact_queue.pop_front();
       compact_queue_lock.Unlock();
-      compact_prefix(prefix);
+      compact_range(range.first, range.second);
       compact_queue_lock.Lock();
       continue;
     }
diff --git a/src/os/LevelDBStore.h b/src/os/LevelDBStore.h
index 94a694922479..e4e84107fdf0 100644
--- a/src/os/LevelDBStore.h
+++ b/src/os/LevelDBStore.h
@@ -36,7 +36,7 @@ class LevelDBStore : public KeyValueDB {
   // manage async compactions
   Mutex compact_queue_lock;
   Cond compact_queue_cond;
-  list<string> compact_queue;
+  list< pair<string,string> > compact_queue;
   bool compact_queue_stop;
   class CompactThread : public Thread {
     LevelDBStore *db;
@@ -51,6 +51,21 @@ class LevelDBStore : public KeyValueDB {
 
   void compact_thread_entry();
 
+  void compact_range(const string& start, const string& end) {
+    leveldb::Slice cstart(start);
+    leveldb::Slice cend(end);
+    db->CompactRange(&cstart, &cend);
+  }
+  void compact_range_async(const string& start, const string& end) {
+    Mutex::Locker l(compact_queue_lock);
+    compact_queue.remove(make_pair(start, end));    // prevent unbounded dups
+    compact_queue.push_back(make_pair(start, end));
+    compact_queue_cond.Signal();
+    if (!compact_thread.is_started()) {
+      compact_thread.create();
+    }
+  }
+
 public:
   /// compact the underlying leveldb store
   void compact() {
@@ -59,23 +74,17 @@ public:
 
   /// compact leveldb for all keys with a given prefix
   void compact_prefix(const string& prefix) {
-    // if we combine the prefix with key by adding a '\0' separator,
-    // a char(1) will capture all such keys.
-    string end = prefix;
-    end += (char)1;
-    leveldb::Slice cstart(prefix);
-    leveldb::Slice cend(end);
-    db->CompactRange(&cstart, &cend);
+    compact_range(prefix, past_prefix(prefix));
   }
-
   void compact_prefix_async(const string& prefix) {
-    Mutex::Locker l(compact_queue_lock);
-    compact_queue.remove(prefix);     // prevent unbounded dups
-    compact_queue.push_back(prefix);
-    compact_queue_cond.Signal();
-    if (!compact_thread.is_started()) {
-      compact_thread.create();
-    }
+    compact_range_async(prefix, past_prefix(prefix));
+  }
+
+  void compact_range(const string& prefix, const string& start, const string& end) {
+    compact_range(combine_strings(prefix, start), combine_strings(prefix, end));
+  }
+  void compact_range_async(const string& prefix, const string& start, const string& end) {
+    compact_range_async(combine_strings(prefix, start), combine_strings(prefix, end));
   }
 
   /**