From: Sebastian Wagner <sebastian.wagner@suse.com>
Date: Tue, 5 Mar 2019 16:39:57 +0000 (+0100)
Subject: mgr/orchestrator: remove `(add|test|remove)_stateful_service_rule`
X-Git-Tag: v15.0.0~211^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e267c9000ce248be206264a0d8acb4ab8fa3296f;p=ceph.git

mgr/orchestrator: remove `(add|test|remove)_stateful_service_rule`

Reasons are:

1. No one implemented this till now
2. The distinction between DriveGroups end `tateful_service_rule` is not clear

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
---

diff --git a/src/pybind/mgr/orchestrator.py b/src/pybind/mgr/orchestrator.py
index 598181b501e7..ed6b30e22ccb 100644
--- a/src/pybind/mgr/orchestrator.py
+++ b/src/pybind/mgr/orchestrator.py
@@ -374,37 +374,6 @@ class Orchestrator(object):
         """
         raise NotImplementedError()
 
-    def add_stateful_service_rule(self, service_type, stateful_service_spec,
-                                  placement_spec):
-        """
-        Stateful service rules serve two purposes:
-         - Optionally delegate device selection to the orchestrator
-         - Enable the orchestrator to auto-assimilate new hardware if it
-           matches the placement spec, without any further calls from ceph-mgr.
-
-        To create a confidence-inspiring UI workflow, use test_stateful_service_rule
-        beforehand to show the user where stateful services will be placed
-        if they proceed.
-        """
-        raise NotImplementedError()
-
-    def test_stateful_service_rule(self, service_type, stateful_service_spec,
-                                   placement_spec):
-        """
-        See add_stateful_service_rule.
-        """
-        raise NotImplementedError()
-
-    def remove_stateful_service_rule(self, service_type, id_):
-        """
-        This will remove the *rule* but not the services that were
-        created as a result.  Those should be converted into statically
-        placed services as if they had been created with add_stateful_service,
-        so that they can be removed with remove_stateless_service
-        if desired.
-        """
-        raise NotImplementedError()
-
 
 class UpgradeSpec(object):
     # Request to orchestrator to initiate an upgrade to a particular