From: Nitzan Mordechai <nmordech@ibm.com>
Date: Mon, 23 Mar 2026 13:06:24 +0000 (+0000)
Subject: mgr/mgr_module: fix tox test missing a type annotation
X-Git-Tag: v21.0.0~4^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e2826197531cb0e4c48b79cafaa11098b16456f6;p=ceph.git

mgr/mgr_module: fix tox test missing a type annotation

After changes of PR #67327

Signed-off-by: Nitzan Mordechai <nmordech@ibm.com>
---

diff --git a/src/pybind/mgr/mgr_module.py b/src/pybind/mgr/mgr_module.py
index 79087c5cdf23..7726931da0e0 100644
--- a/src/pybind/mgr/mgr_module.py
+++ b/src/pybind/mgr/mgr_module.py
@@ -677,14 +677,15 @@ class CPlusPlusHandler(logging.Handler):
         if record.levelno >= self.level:
             self._module._ceph_log(self.format(record))
 
+
 class MgrRootHandler(CPlusPlusHandler):
-    def __init__(self, module_inst):
+    def __init__(self, module_inst: 'MgrModuleLoggingMixin') -> None:
         super().__init__(module_inst)
         self.setFormatter(logging.Formatter(
             "[mgr %(levelname)-4s %(name)s] %(message)s"
         ))
 
-    def emit(self, record):
+    def emit(self, record: logging.LogRecord) -> None:
         record.name = "mgr"
         super().emit(record)
 
@@ -723,6 +724,8 @@ class FileHandler(logging.FileHandler):
 
 
 class MgrModuleLoggingMixin(object):
+    module_name: str
+
     def _configure_logging(self,
                            mgr_level: str,
                            module_level: str,
@@ -846,10 +849,13 @@ class MgrModuleLoggingMixin(object):
             log_level = "INFO"
         return log_level
 
-    def getLogger(self, name=None):
+    def getLogger(self, name: Optional[str] = None) -> logging.Logger:
+        logger = getattr(self, '_module_logger', None) \
+            or logging.getLogger(self.module_name)
         if name is None:
-            return self._module_logger
-        return self._module_logger.getChild(name)
+            return logger
+        return logger.getChild(name)
+
 
 class MgrStandbyModule(ceph_module.BaseMgrStandbyModule, MgrModuleLoggingMixin):
     """
diff --git a/src/python-common/ceph/deployment/service_spec.py b/src/python-common/ceph/deployment/service_spec.py
index a6963d4dadcb..2f6d6f944d2f 100644
--- a/src/python-common/ceph/deployment/service_spec.py
+++ b/src/python-common/ceph/deployment/service_spec.py
@@ -936,7 +936,7 @@ class ServiceSpec(object):
         sub_cls: Any = cls._cls(service_type)
         return object.__new__(sub_cls)
 
-    def __getnewargs__(self):
+    def __getnewargs__(self) -> tuple[str]:
         """
         Pickle will pass the return of this function to __new__ upon
         unpickle.  We need to ensure it gets service_type in order