From: Kefu Chai <kchai@redhat.com>
Date: Wed, 11 Jan 2017 06:58:42 +0000 (+0800)
Subject: cmake: version libceph-common to appease dpkg-shlibdeps
X-Git-Tag: v12.0.0~87^2~5
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e2da2e9fa7e305bc7722bec6d94483da6b235175;p=ceph.git

cmake: version libceph-common to appease dpkg-shlibdeps

when packaging debian packages, dpkg-shlibdeps analyzes the linked
shared libraries of the binaries in given package by looking at their
names. but if the name does not include any useful versioning
information, it complains. we have no intention of versioning
libceph-common, as it is merely an internal shared library used by ceph
packages only. but there is no simple way to disable dpkg-shlibdeps'
warning of

  dpkg-shlibdeps: warning: can't extract name and version from library
  name 'libceph-common.so'

other than skipping the dpkg-shlibdeps for the whole package. so let's
just version it anyway.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/ceph.spec.in b/ceph.spec.in
index d673e85d974c..008298fe5133 100644
--- a/ceph.spec.in
+++ b/ceph.spec.in
@@ -1354,7 +1354,7 @@ fi
 %defattr(-,root,root,-)
 %{_libdir}/librados.so.*
 %dir %{_libdir}/ceph
-%{_libdir}/ceph/libceph-common.so
+%{_libdir}/ceph/libceph-common.so.*
 %if %{with lttng}
 %{_libdir}/librados_tp.so.*
 %endif
diff --git a/debian/librados2.install b/debian/librados2.install
index 1d937e8d19e1..c8055fb8cb1d 100644
--- a/debian/librados2.install
+++ b/debian/librados2.install
@@ -1,3 +1,3 @@
 usr/lib/librados.so.*
 usr/lib/librados_tp.so.*
-usr/lib/ceph/libceph-common.so
+usr/lib/ceph/libceph-common.so.*
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index c9afe4100d0f..da71587fcf42 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -566,6 +566,9 @@ target_link_libraries(ceph-common json_spirit erasure_code rt ${LIB_RESOLV}
 if(NOT WITH_SYSTEM_BOOST)
   target_link_libraries(ceph-common ${ZLIB_LIBRARIES})
 endif()
+# appease dpkg-shlibdeps
+set_target_properties(ceph-common PROPERTIES
+  SOVERSION 0)
 install(TARGETS ceph-common DESTINATION ${CMAKE_INSTALL_PKGLIBDIR})
 if(WITH_EMBEDDED)
   add_library(cephd_common STATIC