From: Sage Weil <sage@newdream.net>
Date: Sat, 26 Jun 2021 16:29:09 +0000 (-0400)
Subject: test/cli/crushtool: use 'id' instead of 'ruleset' in crush inputs
X-Git-Tag: v17.1.0~1398^2~12
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e4a299bb03b3d5abc7e8144306a09129d45bec3b;p=ceph.git

test/cli/crushtool: use 'id' instead of 'ruleset' in crush inputs

The 'ruleset' syntax is super-old and misleading.

Signed-off-by: Sage Weil <sage@newdream.net>
---

diff --git a/src/test/cli/crushtool/bad-mappings.crushmap.txt b/src/test/cli/crushtool/bad-mappings.crushmap.txt
index 21b5981914c..f2bb4da5743 100644
--- a/src/test/cli/crushtool/bad-mappings.crushmap.txt
+++ b/src/test/cli/crushtool/bad-mappings.crushmap.txt
@@ -19,7 +19,7 @@ domain root {
 }
 
 rule rule-firstn {
-	ruleset 0
+	id 0
 	type replicated
 	min_size 1
 	max_size 10
@@ -29,7 +29,7 @@ rule rule-firstn {
 }
 
 rule rule-indep {
-	ruleset 1
+	id 1
 	type erasure
 	min_size 1
 	max_size 10
diff --git a/src/test/cli/crushtool/build.t b/src/test/cli/crushtool/build.t
index f50b64084c1..c6aff9d5b63 100644
--- a/src/test/cli/crushtool/build.t
+++ b/src/test/cli/crushtool/build.t
@@ -14,14 +14,14 @@
 # display a warning if there is more than one root
 #
   $ crushtool --outfn "$map" --build --num_osds 5 node straw 2 rack straw 1 
-  The crush rulesets will use the root rack0 (re)
+  The crush rules will use the root rack0 (re)
   and ignore the others.
   There are 3 roots, they can be
   grouped into a single root by appending something like:
     root straw 0
   
 #
-# crush rulesets are generated using the OSDMap helpers
+# crush rules are generated using the OSDMap helpers
 #
   $ CEPH_ARGS="--debug-crush 0" crushtool --outfn "$map" --set-straw-calc-version 0 --build --num_osds 1 root straw 0 --set-chooseleaf-stable 0
   $ crushtool -o "$map.txt" -d "$map"
diff --git a/src/test/cli/crushtool/check-overlapped-rules.crushmap.txt b/src/test/cli/crushtool/check-overlapped-rules.crushmap.txt
index 4be115108b9..b041aa49033 100644
--- a/src/test/cli/crushtool/check-overlapped-rules.crushmap.txt
+++ b/src/test/cli/crushtool/check-overlapped-rules.crushmap.txt
@@ -19,7 +19,7 @@ host host0 {
 }
 
 rule rule-r0 {
-	ruleset 0
+	id 0
 	type replicated
 	min_size 1
 	max_size 3
@@ -29,7 +29,7 @@ rule rule-r0 {
 }
 
 rule rule-r1 {
-	ruleset 0
+	id 0
 	type replicated
 	min_size 1
 	max_size 1
@@ -39,7 +39,7 @@ rule rule-r1 {
 }
 
 rule rule-r2 {
-	ruleset 0
+	id 0
 	type replicated
 	min_size 1
 	max_size 2
@@ -49,7 +49,7 @@ rule rule-r2 {
 }
 
 rule rule-r3 {
-	ruleset 0
+	id 0
 	type replicated
 	min_size 2
 	max_size 3
@@ -59,7 +59,7 @@ rule rule-r3 {
 }
 
 rule rule-r4 {
-	ruleset 0
+	id 0
 	type replicated
 	min_size 4
 	max_size 5
@@ -69,7 +69,7 @@ rule rule-r4 {
 }
 
 rule rule-e0 {
-	ruleset 0
+	id 0
 	type erasure
 	min_size 1
 	max_size 10
@@ -79,7 +79,7 @@ rule rule-e0 {
 }
 
 rule rule-e1 {
-	ruleset 1
+	id 1
 	type erasure
 	min_size 1
 	max_size 10
diff --git a/src/test/cli/crushtool/empty-default.cushmap.txt b/src/test/cli/crushtool/empty-default.cushmap.txt
index fc24d17aed9..f52a2cb1de7 100644
--- a/src/test/cli/crushtool/empty-default.cushmap.txt
+++ b/src/test/cli/crushtool/empty-default.cushmap.txt
@@ -29,8 +29,8 @@ root default {
 }
 
 # rules
-rule replicated_ruleset {
-    ruleset 0
+rule replicated_rule {
+    id 0
     type replicated
     min_size 1
     max_size 10
diff --git a/src/test/cli/crushtool/missing-bucket.crushmap.txt b/src/test/cli/crushtool/missing-bucket.crushmap.txt
index 6d40af3297d..80f44cd7ae0 100644
--- a/src/test/cli/crushtool/missing-bucket.crushmap.txt
+++ b/src/test/cli/crushtool/missing-bucket.crushmap.txt
@@ -19,7 +19,7 @@ domain root {
 }
 
 rule rule-bad {
-	ruleset 0
+	id 0
 	type replicated
 	min_size 1
 	max_size 10
@@ -29,7 +29,7 @@ rule rule-bad {
 }
 
 rule rule-good {
-	ruleset 1
+	id 1
 	type erasure
 	min_size 1
 	max_size 10
diff --git a/src/test/cli/crushtool/multitype.before b/src/test/cli/crushtool/multitype.before
index 2727dcae158..a787bdc3407 100644
--- a/src/test/cli/crushtool/multitype.before
+++ b/src/test/cli/crushtool/multitype.before
@@ -57,7 +57,7 @@ cluster cluster0 {
 
 # rules
 rule data {
-	ruleset 0
+	id 0
 	type replicated
 	min_size 1
 	max_size 10
@@ -66,7 +66,7 @@ rule data {
 	step emit
 }
 rule metadata {
-	ruleset 1
+	id 1
 	type replicated
 	min_size 1
 	max_size 10
@@ -75,7 +75,7 @@ rule metadata {
 	step emit
 }
 rule rbd {
-	ruleset 2
+	id 2
 	type replicated
 	min_size 1
 	max_size 10
diff --git a/src/test/cli/crushtool/output-csv.t b/src/test/cli/crushtool/output-csv.t
index ad99597436a..0769dacd52d 100644
--- a/src/test/cli/crushtool/output-csv.t
+++ b/src/test/cli/crushtool/output-csv.t
@@ -1,4 +1,4 @@
-# first test that CSV files are created for each ruleset 
+# first test that CSV files are created for each rule
 $ crushtool -i five-devices.crushmap --test --num-rep 1 --min-x 0 --max-x 9 --output-csv
 $ if [ ! -f data-absolute_weights.csv ]; then echo FAIL; fi
 $ if [ ! -f data-batch_device_expected_utilization_all.csv ]; then echo FAIL; fi 
diff --git a/src/test/cli/crushtool/rules.txt b/src/test/cli/crushtool/rules.txt
index a8be9e95867..4844cf8911e 100644
--- a/src/test/cli/crushtool/rules.txt
+++ b/src/test/cli/crushtool/rules.txt
@@ -42,7 +42,7 @@ root default {
 
 # rules
 rule data {
-	ruleset 0
+	id 0
 	type replicated
 	min_size 1
 	max_size 10
diff --git a/src/test/cli/crushtool/show-choose-tries.txt b/src/test/cli/crushtool/show-choose-tries.txt
index 7826fec36d9..9a961c8c81e 100644
--- a/src/test/cli/crushtool/show-choose-tries.txt
+++ b/src/test/cli/crushtool/show-choose-tries.txt
@@ -24,8 +24,8 @@ root root {
 	item device2 weight 1.00000
 }
 
-rule first_ruleset {
-	ruleset 0
+rule first_rule {
+	id 0
 	type replicated
 	min_size 1
 	max_size 10
@@ -34,8 +34,8 @@ rule first_ruleset {
 	step emit
 }
 
-rule indep_ruleset {
-    ruleset 1
+rule indep_rule {
+    id 1
     type erasure
     min_size 3
     max_size 20
diff --git a/src/test/cli/crushtool/simple.template.adj.one b/src/test/cli/crushtool/simple.template.adj.one
index ff268e13f26..94c243de76d 100644
--- a/src/test/cli/crushtool/simple.template.adj.one
+++ b/src/test/cli/crushtool/simple.template.adj.one
@@ -26,7 +26,7 @@ cluster cluster0 {
 
 # rules
 rule data {
-	ruleset 0
+	id 0
 	type replicated
 	min_size 1
 	max_size 10
@@ -35,7 +35,7 @@ rule data {
 	step emit
 }
 rule metadata {
-	ruleset 1
+	id 1
 	type replicated
 	min_size 1
 	max_size 10
@@ -44,7 +44,7 @@ rule metadata {
 	step emit
 }
 rule rbd {
-	ruleset 2
+	id 2
 	type replicated
 	min_size 1
 	max_size 10
diff --git a/src/test/cli/crushtool/simple.template.multitree b/src/test/cli/crushtool/simple.template.multitree
index 6cf1b217792..05d18b2761d 100644
--- a/src/test/cli/crushtool/simple.template.multitree
+++ b/src/test/cli/crushtool/simple.template.multitree
@@ -40,7 +40,7 @@ cluster cluster1 {
 
 # rules
 rule data {
-	ruleset 0
+	id 0
 	type replicated
 	min_size 1
 	max_size 10
@@ -49,7 +49,7 @@ rule data {
 	step emit
 }
 rule metadata {
-	ruleset 1
+	id 1
 	type replicated
 	min_size 1
 	max_size 10
@@ -58,7 +58,7 @@ rule metadata {
 	step emit
 }
 rule rbd {
-	ruleset 2
+	id 2
 	type replicated
 	min_size 1
 	max_size 10
diff --git a/src/test/cli/crushtool/simple.template.one b/src/test/cli/crushtool/simple.template.one
index 22acd02d2b4..4dcb1505d85 100644
--- a/src/test/cli/crushtool/simple.template.one
+++ b/src/test/cli/crushtool/simple.template.one
@@ -28,7 +28,7 @@ cluster cluster0 {
 
 # rules
 rule data {
-	ruleset 0
+	id 0
 	type replicated
 	min_size 1
 	max_size 10
@@ -37,7 +37,7 @@ rule data {
 	step emit
 }
 rule metadata {
-	ruleset 1
+	id 1
 	type replicated
 	min_size 1
 	max_size 10
@@ -46,7 +46,7 @@ rule metadata {
 	step emit
 }
 rule rbd {
-	ruleset 2
+	id 2
 	type replicated
 	min_size 1
 	max_size 10
diff --git a/src/test/cli/crushtool/simple.template.three b/src/test/cli/crushtool/simple.template.three
index 22acd02d2b4..4dcb1505d85 100644
--- a/src/test/cli/crushtool/simple.template.three
+++ b/src/test/cli/crushtool/simple.template.three
@@ -28,7 +28,7 @@ cluster cluster0 {
 
 # rules
 rule data {
-	ruleset 0
+	id 0
 	type replicated
 	min_size 1
 	max_size 10
@@ -37,7 +37,7 @@ rule data {
 	step emit
 }
 rule metadata {
-	ruleset 1
+	id 1
 	type replicated
 	min_size 1
 	max_size 10
@@ -46,7 +46,7 @@ rule metadata {
 	step emit
 }
 rule rbd {
-	ruleset 2
+	id 2
 	type replicated
 	min_size 1
 	max_size 10
diff --git a/src/test/cli/crushtool/straw2.txt b/src/test/cli/crushtool/straw2.txt
index 65755e4d14e..754f45e10b4 100644
--- a/src/test/cli/crushtool/straw2.txt
+++ b/src/test/cli/crushtool/straw2.txt
@@ -30,7 +30,7 @@ default default {
 }
 
 # rules
-rule replicated_ruleset {
+rule replicated_rule {
 	id 0
 	type replicated
 	min_size 1
diff --git a/src/test/cli/crushtool/test-map-firstn-indep.txt b/src/test/cli/crushtool/test-map-firstn-indep.txt
index 8fd2ea9eced..59bc09811b6 100644
--- a/src/test/cli/crushtool/test-map-firstn-indep.txt
+++ b/src/test/cli/crushtool/test-map-firstn-indep.txt
@@ -419,7 +419,7 @@ default root {
 
 # rules
 rule myrule {
-	ruleset 0
+	id 0
 	type replicated
 	min_size 1
 	max_size 10
@@ -430,7 +430,7 @@ rule myrule {
 }
 
 rule myrule1 {
-	ruleset 1
+	id 1
 	type replicated
 	min_size 1
 	max_size 10
diff --git a/src/test/crush/crush_weights.sh b/src/test/crush/crush_weights.sh
index 5b93f3a1afb..7aec52e8765 100755
--- a/src/test/crush/crush_weights.sh
+++ b/src/test/crush/crush_weights.sh
@@ -33,7 +33,7 @@ domain root {
 }
 # rules
 rule data {
-    ruleset 0
+    id 0
     type replicated
     min_size 1
     max_size 10