From: Samuel Just <sam.just@inktank.com>
Date: Tue, 5 Mar 2013 22:35:39 +0000 (-0800)
Subject: OSD: lock not needed in ~DeletingState()
X-Git-Tag: v0.60~78^2~21
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e4bf1bcab159d7c5b720f5da01877c0f67c16d16;p=ceph.git

OSD: lock not needed in ~DeletingState()

No further refs to the object can remain at this point.
Furthermore, the callbacks might lock mutexes of their
own.

Backport: bobtail
Fixes: #4378
Signed-off-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: Greg Farnum <greg@inktank.com>
---

diff --git a/src/osd/OSD.h b/src/osd/OSD.h
index 500944e2f47c..23d2537b7457 100644
--- a/src/osd/OSD.h
+++ b/src/osd/OSD.h
@@ -150,7 +150,6 @@ public:
     on_deletion_complete.push_front(completion);
   }
   ~DeletingState() {
-    Mutex::Locker l(lock);
     for (list<Context *>::iterator i = on_deletion_complete.begin();
 	 i != on_deletion_complete.end();
 	 ++i) {