From: Pavel Reichl <preichl@redhat.com>
Date: Tue, 20 Sep 2022 08:38:10 +0000 (+0200)
Subject: ext4/044: Add missing check for return value
X-Git-Tag: v2022.09.25~8
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e635c29e187db03735fc867d930f50ad0530d2b7;p=xfstests-dev.git

ext4/044: Add missing check for return value

When calling _within_tolerance either return value or text output
should be checked. Otherwise the function is useless for a test.

Signed-off-by: Pavel Reichl <preichl@redhat.com>
Reviewed-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Zorro Lang <zlang@kernel.org>
---

diff --git a/tests/ext4/044 b/tests/ext4/044
index 158e2ac5..50de5a40 100755
--- a/tests/ext4/044
+++ b/tests/ext4/044
@@ -18,8 +18,6 @@ _require_scratch
 _require_test_program "t_get_file_time"
 _require_metadata_journaling
 
-echo "Silence is golden"
-
 echo "Test timestamps with 256 inode size one device $SCRATCH_DEV" >$seqres.full
 _scratch_mkfs -t ext3 -I 256 >> $seqres.full 2>&1
 _scratch_mount
@@ -49,9 +47,9 @@ nsec_mtime: $nsec_mtime, nsec_ctime: $nsec_ctime, cur_time[ns]: $nsec)"
 fi
 
 # Check difference between file time and current time
-_within_tolerance "sec_atime" $sec_atime $sec 1
-_within_tolerance "sec_mtime" $sec_mtime $sec 1
-_within_tolerance "sec_ctime" $sec_ctime $sec 1
+_within_tolerance "sec_atime" $sec_atime $sec 1 -v
+_within_tolerance "sec_mtime" $sec_mtime $sec 1 -v
+_within_tolerance "sec_ctime" $sec_ctime $sec 1 -v
 
 _scratch_unmount >> $seqres.full 2>&1
 
diff --git a/tests/ext4/044.out b/tests/ext4/044.out
index 12a61dc4..8a3a8072 100644
--- a/tests/ext4/044.out
+++ b/tests/ext4/044.out
@@ -1,2 +1,4 @@
 QA output created by 044
-Silence is golden
+sec_atime is in range
+sec_mtime is in range
+sec_ctime is in range