From: Rishabh Dave <ridave@redhat.com>
Date: Wed, 10 Jun 2020 13:47:28 +0000 (+0530)
Subject: vstart_runner: set omit_sudo to True by default
X-Git-Tag: v16.1.0~2032^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e68736961fa23ecabaef0fd51b138c3d21c5d76e;p=ceph.git

vstart_runner: set omit_sudo to True by default

Let's set omit_sudo to True by default since we don't to run
commands with sudo on developer's machine as far as possible.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
---

diff --git a/qa/tasks/vstart_runner.py b/qa/tasks/vstart_runner.py
index aae37a187d51..14cdb28f4bcc 100644
--- a/qa/tasks/vstart_runner.py
+++ b/qa/tasks/vstart_runner.py
@@ -356,9 +356,12 @@ class LocalRemote(object):
     def run(self, **kwargs):
         return self._do_run(**kwargs)
 
+    # XXX: omit_sudo is set to True since using sudo can change the ownership
+    # of files which becomes problematic for following executions of
+    # vstart_runner.py.
     def _do_run(self, args, check_status=True, wait=True, stdout=None,
                 stderr=None, cwd=None, stdin=None, logger=None, label=None,
-                env=None, timeout=None, omit_sudo=False):
+                env=None, timeout=None, omit_sudo=True):
         args = self._perform_checks_and_return_list_of_args(args, omit_sudo)
 
         # We have to use shell=True if any run.Raw was present, e.g. &&