From: Sylvain Munaut <tnt@246tNt.com>
Date: Tue, 31 Jul 2012 18:54:29 +0000 (-0700)
Subject: secret: return error on empty secret
X-Git-Tag: v0.50~4
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e775ce52ab5af5d7d6ec330a68d01af2f112a4fc;p=ceph.git

secret: return error on empty secret

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
---

diff --git a/src/common/secret.c b/src/common/secret.c
index 365782ff04fe..11ca8bf4e5d7 100644
--- a/src/common/secret.c
+++ b/src/common/secret.c
@@ -58,6 +58,11 @@ static int set_kernel_secret(const char *secret, const char *key_name)
   char payload[((secret_len * 3) / 4) + 4];
   char error_buf[80];
 
+  if (!secret_len) {
+    fprintf(stderr, "secret is empty.\n");
+    return -EINVAL;
+  }
+
   ret = ceph_unarmor(payload, payload+sizeof(payload), secret, secret+secret_len);
   if (ret < 0) {
     fprintf(stderr, "secret is not valid base64: %s.\n",