From: Yan, Zheng <zyan@redhat.com>
Date: Wed, 18 Dec 2019 09:01:23 +0000 (+0800)
Subject: mds: don't add metadata to session close message
X-Git-Tag: v14.2.8~65^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e7afc576d92ac66fcd9af22ade489a5ee9ee8c15;p=ceph.git

mds: don't add metadata to session close message

Old version kclient does not recognize session message with metatda.

Fixes: https://tracker.ceph.com/issues/43336
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
(cherry picked from commit de2f57b4704e6e23ed27f531b6f6f3b825b9355f)

Conflicts:
        src/mds/Server.cc
- nautilus uses "MClientSession::create" instead of "make_message"
---

diff --git a/src/mds/Server.cc b/src/mds/Server.cc
index 8dfeef698df..7f31d47c7f6 100644
--- a/src/mds/Server.cc
+++ b/src/mds/Server.cc
@@ -1261,7 +1261,6 @@ void Server::handle_client_reconnect(const MClientReconnect::const_ref &m)
   if (!session->is_open()) {
     dout(0) << " ignoring msg from not-open session" << *m << dendl;
     auto reply = MClientSession::create(CEPH_SESSION_CLOSE);
-    reply->metadata["error_string"] = "session is not open";
     mds->send_message(reply, m->get_connection());
     return;
   }