From: Kamoltat Sirivadhna <ksirivad@redhat.com>
Date: Fri, 18 Jul 2025 04:58:26 +0000 (+0000)
Subject: src/mon/Elector.cc: Improve logging for the elector
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e7cafc2af5838584d471de97b6ef31dc0e6f7dcc;p=ceph.git

src/mon/Elector.cc: Improve logging for the elector

Fixes: https://tracker.ceph.com/issues/71344

Signed-off-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
---

diff --git a/src/mon/Elector.cc b/src/mon/Elector.cc
index bfc854d6bdc..e70e8d16859 100644
--- a/src/mon/Elector.cc
+++ b/src/mon/Elector.cc
@@ -454,7 +454,10 @@ void Elector::begin_peer_ping(int peer)
 {
   dout(20) << __func__ << " with " << peer << dendl;
   if (live_pinging.count(peer)) {
-    dout(20) << peer << " already in live_pinging ... return " << dendl;
+    // This peer is already being pinged
+    // so we don't need to schedule another ping_check
+    // against it, ping_check will call itself because it is self-sustaining.
+    dout(20) << peer << " is already being pinged ... return " << dendl;
     return;
   }
   // Check if quorum feature is not set and we are in
@@ -482,7 +485,8 @@ void Elector::begin_peer_ping(int peer)
       << " no need to schedule ping_check" << dendl;
     return;
   }
-  dout(30) << "schedule ping_check against peer: " << peer << dendl;
+  dout(30) << "schedule ping_check against peer: "
+    << peer << " every " << ping_timeout / PING_DIVISOR << "s" << dendl;
   mon->timer.add_event_after(ping_timeout / PING_DIVISOR,
 			     new C_MonContext{mon, [this, peer](int) {
 				 ping_check(peer);
@@ -511,7 +515,7 @@ bool Elector::send_peer_ping(int peer, const utime_t *n)
   MMonPing *ping = new MMonPing(MMonPing::PING, now, peer_tracker.get_encoded_bl());
   mon->messenger->send_to_mon(ping, mon->monmap->get_addrs(peer));
   peer_sent_ping[peer] = now;
-  dout(20) << " sent ping successfully to peer: " << peer << dendl;
+  dout(20) << " sent ping to peer: " << peer << " at " << now << dendl;
   return true;
 }
 
@@ -559,7 +563,9 @@ void Elector::ping_check(int peer)
     }
   }
 
-  dout(30) << "schedule " << __func__ << " against peer: "<< peer << dendl;
+  dout(30) << "Scheduling next ping_check for peer "
+    << peer << " in " << ping_timeout / PING_DIVISOR
+    << "s (recursively call ping_check until connection state changes)" << dendl;
   mon->timer.add_event_after(ping_timeout / PING_DIVISOR,
 			     new C_MonContext{mon, [this, peer](int) {
 				 ping_check(peer);