From: Sage Weil Date: Mon, 2 Dec 2013 06:21:31 +0000 (-0800) Subject: Partial revert "mon: osd pool set syntax relaxed, modify unit tests" X-Git-Tag: v0.73~6 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e80ab94bf44e102fcd87d16dc11e38ca4c0eeadb;p=ceph.git Partial revert "mon: osd pool set syntax relaxed, modify unit tests" This reverts commit 08327fed8213a5d24cd642e12b38a171b98924cb, except for the hashpspool bit. We switched back to an integer argument in commit 337195f04653eed8e8f153a5b074f3bd48408998. Signed-off-by: Sage Weil --- diff --git a/src/test/pybind/test_ceph_argparse.py b/src/test/pybind/test_ceph_argparse.py index f44adf778909..a6d973b2264c 100755 --- a/src/test/pybind/test_ceph_argparse.py +++ b/src/test/pybind/test_ceph_argparse.py @@ -945,14 +945,20 @@ class TestOSD(TestArgparse): 'pg_num', 'pgp_num', 'crush_ruleset', 'hashpspool'): self.assert_valid_command(['osd', 'pool', - 'set', 'poolname', var, 'value']) + 'set', 'poolname', var, '-1']) assert_equal({}, validate_command(sigdict, ['osd', 'pool', 'set'])) assert_equal({}, validate_command(sigdict, ['osd', 'pool', 'set', 'poolname'])) assert_equal({}, validate_command(sigdict, ['osd', 'pool', 'set', 'poolname', - 'size', 'value', + 'size', 'invalid'])) + assert_equal({}, validate_command(sigdict, ['osd', 'pool', + 'set', 'poolname', + 'invalid', '-1'])) + assert_equal({}, validate_command(sigdict, ['osd', 'pool', + 'set', 'poolname', + 'size', '-1', 'toomany'])) def test_pool_set_quota(self):