From: fxtack <fxtack@foxmail.com>
Date: Thu, 25 Dec 2025 05:17:19 +0000 (+0800)
Subject: The wait_for_recovery_toofull function was referencing an undefined
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=e8cbb658a5a22b70cc0ba89e35de013494898672;p=ceph-ci.git

The wait_for_recovery_toofull function was referencing an undefined
variable '$ret' instead of the correct '$?' to check the exit status
of the wait_for_state function call.

This fix ensures the function properly checks the return value and
handles recovery timeout scenarios correctly in the OSD recovery
space test.

Fixes: undefined variable reference in test script
Signed-off-by: fxtack <fxtack@foxmail.com>
---

diff --git a/qa/standalone/osd/osd-recovery-space.sh b/qa/standalone/osd/osd-recovery-space.sh
index 67fe2e91dfa..a9584757792 100755
--- a/qa/standalone/osd/osd-recovery-space.sh
+++ b/qa/standalone/osd/osd-recovery-space.sh
@@ -76,7 +76,7 @@ function wait_for_state() {
 function wait_for_recovery_toofull() {
     local timeout=$1
     wait_for_state recovery_toofull $timeout
-    if [ $ret -ne 0 ]; then
+    if [ $? -ne 0 ]; then
       echo "Error: Recovery toofull timeout"
       return 1
     fi