From: Patrick Donnelly Date: Tue, 27 May 2025 23:25:42 +0000 (-0400) Subject: auth: cleanup error message formatting X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=e91a7163f5afc41bb2cc895291c55b05fe6a3c45;p=ceph-ci.git auth: cleanup error message formatting Signed-off-by: Patrick Donnelly (cherry picked from commit 5df283a98114024d852422b43624810bcf5fe8cb) --- diff --git a/src/auth/cephx/CephxSessionHandler.cc b/src/auth/cephx/CephxSessionHandler.cc index f4c1af6e591..300037af357 100644 --- a/src/auth/cephx/CephxSessionHandler.cc +++ b/src/auth/cephx/CephxSessionHandler.cc @@ -192,13 +192,13 @@ int CephxSessionHandler::check_message_signature(Message *m) if (sig != m->get_footer().sig) { // Should have been signed, but signature check failed. PLR if (!(m->get_footer().flags & CEPH_MSG_FOOTER_SIGNED)) { - ldout(cct, 0) << "SIGN: MSG " << m->get_seq() << " Sender did not set CEPH_MSG_FOOTER_SIGNED." << dendl; + ldout(cct, 0) << "SIGN: MSG seq " << m->get_seq() << " Sender did not set CEPH_MSG_FOOTER_SIGNED." << dendl; } - ldout(cct, 0) << "SIGN: MSG " << m->get_seq() << " Message signature does not match contents." << dendl; - ldout(cct, 0) << "SIGN: MSG " << m->get_seq() << "Signature on message:" << dendl; - ldout(cct, 0) << "SIGN: MSG " << m->get_seq() << " sig: " << m->get_footer().sig << dendl; - ldout(cct, 0) << "SIGN: MSG " << m->get_seq() << "Locally calculated signature:" << dendl; - ldout(cct, 0) << "SIGN: MSG " << m->get_seq() << " sig_check:" << sig << dendl; + ldout(cct, 0) << "SIGN: MSG seq " << m->get_seq() << " Message signature does not match contents." << dendl; + ldout(cct, 0) << "SIGN: MSG seq " << m->get_seq() << " Signature on message:" << dendl; + ldout(cct, 0) << "SIGN: MSG seq " << m->get_seq() << " sig: " << m->get_footer().sig << dendl; + ldout(cct, 0) << "SIGN: MSG seq " << m->get_seq() << " Locally calculated signature:" << dendl; + ldout(cct, 0) << "SIGN: MSG seq " << m->get_seq() << " sig_check: " << sig << dendl; // For the moment, printing an error message to the log and // returning failure is sufficient. In the long term, we should