From: Michal Jarzabek Date: Sun, 18 Sep 2016 22:37:50 +0000 (+0100) Subject: osd/OSD.h: move some members under private X-Git-Tag: v11.0.1~161^2 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=e9e918fcb7c87149a0d3742b51485014220c6cf8;p=ceph-ci.git osd/OSD.h: move some members under private Signed-off-by: Michal Jarzabek --- diff --git a/src/osd/OSD.h b/src/osd/OSD.h index 2e86ce13a31..8d1511fe1e8 100644 --- a/src/osd/OSD.h +++ b/src/osd/OSD.h @@ -845,7 +845,6 @@ public: Objecter *objecter; Finisher objecter_finisher; - // -- Watch -- Mutex watch_lock; SafeTimer watch_timer; @@ -907,6 +906,7 @@ public: entity_inst_t()))); } +private: // -- pg recovery and associated throttling -- Mutex recovery_lock; list > awaiting_throttle; @@ -918,10 +918,24 @@ public: #ifdef DEBUG_RECOVERY_OIDS map > recovery_oids; #endif - void start_recovery_op(PG *pg, const hobject_t& soid); - void finish_recovery_op(PG *pg, const hobject_t& soid, bool dequeue); bool _recover_now(uint64_t *available_pushes); void _maybe_queue_recovery(); + void _queue_for_recovery( + pair p, uint64_t reserved_pushes) { + assert(recovery_lock.is_locked_by_me()); + pair to_queue = make_pair( + p.second, + PGQueueable( + PGRecovery(p.first, reserved_pushes), + cct->_conf->osd_recovery_cost, + cct->_conf->osd_recovery_priority, + ceph_clock_now(cct), + entity_inst_t())); + op_wq.queue(to_queue); + } +public: + void start_recovery_op(PG *pg, const hobject_t& soid); + void finish_recovery_op(PG *pg, const hobject_t& soid, bool dequeue); void release_reserved_pushes(uint64_t pushes) { Mutex::Locker l(recovery_lock); assert(recovery_ops_reserved >= pushes); @@ -973,19 +987,6 @@ public: _maybe_queue_recovery(); } - void _queue_for_recovery( - pair p, uint64_t reserved_pushes) { - assert(recovery_lock.is_locked_by_me()); - pair to_queue = make_pair( - p.second, - PGQueueable( - PGRecovery(p.first, reserved_pushes), - cct->_conf->osd_recovery_cost, - cct->_conf->osd_recovery_priority, - ceph_clock_now(cct), - entity_inst_t())); - op_wq.queue(to_queue); - } // osd map cache (past osd maps) Mutex map_cache_lock;