From: Sage Weil Date: Wed, 22 Jul 2009 18:25:51 +0000 (-0700) Subject: kclient: msgr cleanup X-Git-Tag: v0.11~3 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=ea54a6a20749328be75709fd13157ec46dbf1973;p=ceph.git kclient: msgr cleanup --- diff --git a/src/kernel/messenger.c b/src/kernel/messenger.c index 845faf2a3ea2..a9d71458864c 100644 --- a/src/kernel/messenger.c +++ b/src/kernel/messenger.c @@ -11,6 +11,27 @@ #include "super.h" #include "messenger.h" +/* + * Ceph uses the messenger to exchange ceph_msg messages with other + * hosts in the system. The messenger provides ordered and reliable + * delivery. It tolerates TCP disconnects by reconnecting (with + * exponential backoff) in the case of a fault (disconnection, bad + * crc, protocol error). Acks allow sent messages to be discarded by + * the sender. + * + * The network topology is flat: there is no "client" or "server," and + * any node can initiate a connection (i.e., send messages) to any + * other node. There is a fair bit of complexity to handle the + * "connection race" case where two nodes are simultaneously + * connecting to each other so that the end result is a single + * session. + * + * The messenger can also send messages in "lossy" mode, where there + * is no error recovery or connect retry... the message is just + * dropped if something goes wrong. + */ + + /* static tag bytes (protocol control messages) */ static char tag_msg = CEPH_MSGR_TAG_MSG; static char tag_ack = CEPH_MSGR_TAG_ACK; diff --git a/src/kernel/messenger.h b/src/kernel/messenger.h index 78b8ea3ccaa3..4ccd01c8bb6c 100644 --- a/src/kernel/messenger.h +++ b/src/kernel/messenger.h @@ -10,25 +10,6 @@ #include "types.h" -/* - * Ceph uses the messenger to exchange ceph_msg messages with - * other hosts in the system. The messenger provides ordered and - * reliable delivery. It tolerates TCP disconnects by reconnecting - * (with exponential backoff) in the case of a fault (disconnection, - * bad crc, protocol error). Acks allow sent messages to be discarded - * by the sender. - * - * The network topology is flat: there is no "client" or "server," and - * any node can initiate a connection (i.e., send messages) to any other - * node. There is a fair bit of complexity to handle the "connection - * race" case where two nodes are simultaneously connecting to each other - * so that the end result is a single session. - * - * The messenger can also send messages in "lossy" mode, where there is - * no error recovery or connect retry... the message is just dropped if - * something goes wrong. - */ - struct ceph_msg; #define IPQUADPORT(n) \