From: Rishabh Dave Date: Mon, 18 Apr 2022 19:21:04 +0000 (+0530) Subject: qa/cephfs: add check in test_acls.py X-Git-Tag: v18.0.0~908^2 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=eac83582f3c3f028912685ecb6261bba0e20c321;p=ceph-ci.git qa/cephfs: add check in test_acls.py In xfstests-dev, "./check generic/abcd" doesn't end in error even when there is no test abcd in generic. It's better to check the stdout to verify success and print the returncode, stdout and stderr of the command in logs so that such error can be found out by reading logs. Signed-off-by: Rishabh Dave --- diff --git a/qa/tasks/cephfs/test_acls.py b/qa/tasks/cephfs/test_acls.py index 03665d4dad5..5a6e03472f0 100644 --- a/qa/tasks/cephfs/test_acls.py +++ b/qa/tasks/cephfs/test_acls.py @@ -38,3 +38,7 @@ class TestACLs(XFSTestsDev): stdout, stderr = proc.stdout.getvalue(), proc.stderr.getvalue() log.info(f'Command stdout -\n{stdout}') log.info(f'Command stderr -\n{stderr}') + + self.assertEqual(proc.returncode, 0) + success_line = 'Passed all 1 tests' + self.assertIn(success_line, stdout)