From: Sage Weil <sage@newdream.net>
Date: Wed, 20 Jan 2021 18:34:55 +0000 (-0600)
Subject: mgr/devicehealth: fix 'device monitoring on|off' return value
X-Git-Tag: v16.2.0~237^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=ebf37507535d43a29ce490c4a6e47bc247d08d30;p=ceph.git

mgr/devicehealth: fix 'device monitoring on|off' return value

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 0ee2b2b807706c3e53d4edc7f2ca0211b2a454da)
---

diff --git a/src/pybind/mgr/devicehealth/module.py b/src/pybind/mgr/devicehealth/module.py
index 9b33c50b20f7..1f4148bb8b68 100644
--- a/src/pybind/mgr/devicehealth/module.py
+++ b/src/pybind/mgr/devicehealth/module.py
@@ -168,6 +168,7 @@ class Module(MgrModule):
         '''
         self.set_module_option('enable_monitoring', True)
         self.event.set()
+        return 0, '', ''
 
     @CLICommand('device monitoring off',
                 perm='rw')
@@ -177,6 +178,7 @@ class Module(MgrModule):
         '''
         self.set_module_option('enable_monitoring', False)
         self.set_health_checks({})  # avoid stuck health alerts
+        return 0, '', ''
 
     @CLICommand('device predict-life-expectancy',
                 perm='r')