From: Greg Farnum <greg@inktank.com>
Date: Tue, 10 Dec 2013 18:23:03 +0000 (-0800)
Subject: Elector: use monitor's encoded command sets instead of our own
X-Git-Tag: v0.75~125^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=ec609cacdefe981860c68f71acbcd27523721ecd;p=ceph.git

Elector: use monitor's encoded command sets instead of our own

Signed-off-by: Greg Farnum <greg@inktank.com>
---

diff --git a/src/mon/Elector.cc b/src/mon/Elector.cc
index 6518822adb24..25976f25ddff 100644
--- a/src/mon/Elector.cc
+++ b/src/mon/Elector.cc
@@ -106,18 +106,11 @@ void Elector::defer(int who)
     electing_me = false;
   }
 
-  // encode my commands for transmission
-  if(!my_supported_commands.length()) {
-    const MonCommand *cmds;
-    int cmdsize;
-    get_locally_supported_monitor_commands(&cmds, &cmdsize);
-    MonCommand::encode_array(cmds, cmdsize, my_supported_commands);
-  }
   // ack them
   leader_acked = who;
   ack_stamp = ceph_clock_now(g_ceph_context);
   MMonElection *m = new MMonElection(MMonElection::OP_ACK, epoch, mon->monmap);
-  m->commands = my_supported_commands;
+  m->commands = mon->get_supported_commands_bl();
   mon->messenger->send_message(m, mon->monmap->get_inst(who));
   
   // set a timer
@@ -180,22 +173,16 @@ void Elector::victory()
   assert(epoch % 2 == 1);  // election
   bump_epoch(epoch+1);     // is over!
 
-  // calculate my supported commands for peons to advertise
-  bufferlist *cmds_bl = NULL;
+  // decide my supported commands for peons to advertise
+  const bufferlist *cmds_bl = NULL;
   const MonCommand *cmds;
   int cmdsize;
-  if (!use_classic_commands) {
-    get_locally_supported_monitor_commands(&cmds, &cmdsize);
-    if(!my_supported_commands.length()) {
-      MonCommand::encode_array(cmds, cmdsize, my_supported_commands);
-    }
-    cmds_bl = &my_supported_commands;
-  } else {
+  if (use_classic_commands) {
     get_classic_monitor_commands(&cmds, &cmdsize);
-    if (!classic_commands.length()){
-      MonCommand::encode_array(cmds, cmdsize, classic_commands);
-    }
-    cmds_bl = &classic_commands;
+    cmds_bl = &mon->get_classic_commands_bl();
+  } else {
+    get_locally_supported_monitor_commands(&cmds, &cmdsize);
+    cmds_bl = &mon->get_supported_commands_bl();
   }
   
   // tell everyone!
diff --git a/src/mon/Elector.h b/src/mon/Elector.h
index e59fbf07c6b5..bee3b3082332 100644
--- a/src/mon/Elector.h
+++ b/src/mon/Elector.h
@@ -115,8 +115,6 @@ class Elector {
    */
   map<int, uint64_t> acked_me;
   set<int> classic_mons;
-  bufferlist my_supported_commands;
-  bufferlist classic_commands;
   /**
    * @}
    */