From: Sage Weil <sage@redhat.com>
Date: Thu, 15 Sep 2016 19:38:01 +0000 (-0400)
Subject: os/ObjectStore: clarify clone_range semantics
X-Git-Tag: v11.0.1~154^2~3
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=ecaa86f867c4bcc25ec7327cdabce611171bc453;p=ceph.git

os/ObjectStore: clarify clone_range semantics

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/os/ObjectStore.h b/src/os/ObjectStore.h
index c3e3fa5ba498..f714e771c89f 100644
--- a/src/os/ObjectStore.h
+++ b/src/os/ObjectStore.h
@@ -1338,6 +1338,11 @@ public:
      * The data portion of the destination object receives a copy of a
      * portion of the data from the source object. None of the other
      * three parts of an object is copied from the source.
+     *
+     * The destination object size may be extended to the dstoff + len.
+     *
+     * The source range *must* overlap with the source object data. If it does
+     * not the result is undefined.
      */
     void clone_range(const coll_t& cid, const ghobject_t& oid, ghobject_t noid,
 		     uint64_t srcoff, uint64_t srclen, uint64_t dstoff) {