From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Wed, 19 Feb 2014 17:02:19 +0000 (+0100)
Subject: FileStore: use !empty() instead of size()
X-Git-Tag: v0.78~138^2~11
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=ede614a70ee4231c85b2eb300f531d11c8919b41;p=ceph.git

FileStore: use !empty() instead of size()

[src/os/FileStore.cc:3635]: (performance) Possible inefficient checking
  for 'omap_set' emptiness.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/os/FileStore.cc b/src/os/FileStore.cc
index 36f500b5606..376c39776db 100644
--- a/src/os/FileStore.cc
+++ b/src/os/FileStore.cc
@@ -3632,7 +3632,7 @@ int FileStore::_setattrs(coll_t cid, const ghobject_t& oid, map<string,bufferptr
     inline_to_set.insert(*p);
   }
 
-  if (spill_out != 1 && omap_set.size()) {
+  if (spill_out != 1 && !omap_set.empty()) {
     chain_fsetxattr(**fd, XATTR_SPILL_OUT_NAME, XATTR_SPILL_OUT,
 		    sizeof(XATTR_SPILL_OUT));
   }