From: Danny Al-Gaaf Date: Fri, 19 Sep 2014 10:06:49 +0000 (+0200) Subject: os/GenericObjectMap.cc: pass big parameter by reference X-Git-Tag: v0.86~45 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=eeb74a1c02deede7c276971b7bd911dd9e044db3;p=ceph.git os/GenericObjectMap.cc: pass big parameter by reference CID 1188142 (#1 of 1): Big parameter passed by value (PASS_BY_VALUE) pass_by_value: Passing parameter header of type GenericObjectMap::_Header (size 176 bytes) by value. Signed-off-by: Danny Al-Gaaf (cherry picked from commit 13b8c92a290ea078af26638fbd23bdb2b8c27bdf) --- diff --git a/src/os/GenericObjectMap.cc b/src/os/GenericObjectMap.cc index 00387ad666d..f6ba11eaf14 100644 --- a/src/os/GenericObjectMap.cc +++ b/src/os/GenericObjectMap.cc @@ -1025,7 +1025,7 @@ void GenericObjectMap::remove_header(const coll_t &cid, } void GenericObjectMap::set_header(const coll_t &cid, const ghobject_t &oid, - _Header header, KeyValueDB::Transaction t) + _Header &header, KeyValueDB::Transaction t) { dout(20) << __func__ << " setting " << header.seq << " cid " << cid << " oid " << oid << " parent seq " diff --git a/src/os/GenericObjectMap.h b/src/os/GenericObjectMap.h index 4a0c99c94b9..b2547952073 100644 --- a/src/os/GenericObjectMap.h +++ b/src/os/GenericObjectMap.h @@ -220,7 +220,7 @@ class GenericObjectMap { KeyValueDB::Transaction t); /// Set leaf node for c and oid to the value of header - void set_header(const coll_t &cid, const ghobject_t &oid, _Header header, + void set_header(const coll_t &cid, const ghobject_t &oid, _Header &header, KeyValueDB::Transaction t); // Move all modify member function to "protect", in order to indicate these