From: Li Wang Date: Thu, 6 Dec 2018 08:45:41 +0000 (+0000) Subject: tools/rados: remove misleading comments X-Git-Tag: v14.1.0~680^2~1 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=efa26b41c046c79bd1e88ce471baa2da13e25139;p=ceph.git tools/rados: remove misleading comments Signed-off-by: Li Wang --- diff --git a/src/common/obj_bencher.cc b/src/common/obj_bencher.cc index 2470cc80c62b..9d0b964671d2 100644 --- a/src/common/obj_bencher.cc +++ b/src/common/obj_bencher.cc @@ -447,7 +447,7 @@ int ObjBencher::write_bench(int secondsToRun, goto ERR; r = aio_write(name[i], i, *contents[i], data.op_size, data.op_size * (i % writes_per_object)); - if (r < 0) { //naughty, doesn't clean up heap + if (r < 0) { goto ERR; } lock.lock(); @@ -519,7 +519,7 @@ int ObjBencher::write_bench(int secondsToRun, goto ERR; r = aio_write(newName, slot, *newContents, data.op_size, data.op_size * (data.started % writes_per_object)); - if (r < 0) {//naughty; doesn't clean up heap space. + if (r < 0) { goto ERR; } name[slot] = newName; @@ -697,7 +697,7 @@ int ObjBencher::seq_read_bench(int seconds_to_run, int num_objects, int concurre create_completion(i, _aio_cb, (void *)&lc); r = aio_read(name[i], i, contents[i].get(), data.op_size, data.op_size * (i % writes_per_object)); - if (r < 0) { //naughty, doesn't clean up heap -- oh, or handle the print thread! + if (r < 0) { cerr << "r = " << r << std::endl; goto ERR; } @@ -934,7 +934,7 @@ int ObjBencher::rand_read_bench(int seconds_to_run, int num_objects, int concurr create_completion(i, _aio_cb, (void *)&lc); r = aio_read(name[i], i, contents[i].get(), data.op_size, data.op_size * (i % writes_per_object)); - if (r < 0) { //naughty, doesn't clean up heap -- oh, or handle the print thread! + if (r < 0) { cerr << "r = " << r << std::endl; goto ERR; }