From: Wei Wang <lightmelodies@outlook.com>
Date: Mon, 29 Jan 2024 08:26:24 +0000 (+0000)
Subject: mon: fix health store size growing infinitely
X-Git-Tag: v16.2.15~7^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=efcddbbd36dd83286df78e3d5064ba638b77d5a5;p=ceph.git

mon: fix health store size growing infinitely

The `check_mutes` wrongly marks `changed` to true, trigger `propose_pending` and block following `maybe_trim` logic (`have_pending` will be always be false); as a result, the health store will never be trimmed.

Signed-off-by: Wei Wang <lightmelodies@outlook.com>
(cherry picked from commit 05a85848a01c443d67564a9904a778acfe19cee5)
---

diff --git a/src/mon/HealthMonitor.cc b/src/mon/HealthMonitor.cc
index 4f0f6fe91276..60e35913a4c4 100644
--- a/src/mon/HealthMonitor.cc
+++ b/src/mon/HealthMonitor.cc
@@ -401,7 +401,7 @@ void HealthMonitor::tick()
 
 bool HealthMonitor::check_mutes()
 {
-  bool changed = true;
+  bool changed = false;
   auto now = ceph_clock_now();
   health_check_map_t all;
   gather_all_health_checks(&all);